You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Deduplicate shared validation in the WASM and WASI smoke runners #642
tools/run_wasm_smoke.mjs and tools/run_wasi_smoke.mjs have different runtime-specific behavior, but they duplicate small pieces of WebAssembly module loading and export validation. The private __wave_ export check is implemented separately in both scripts, so future changes can drift.
Scope
Extract only the common smoke-runner helpers into a small shared module.
Keep browser-specific assertions such as wave_add, wave_features, main, and exported memory in run_wasm_smoke.mjs. Keep WASI setup, preopens, imports, and wasi.start() in run_wasi_smoke.mjs.
Do not merge the two entry points or introduce a general WebAssembly runtime abstraction.
Completion criteria
Both runners use the same private-export validation helper.
Common module-loading code is shared where it does not change runner behavior.
Browser-specific and WASI-specific checks remain in their current entry points.
Existing command-line usage and success/failure behavior remain unchanged.
changed the title [-][Proposal]: Share common validation code between the WASM and WASI smoke runners[/-][+]Share common validation code between the WASM and WASI smoke runners[/+]on Sep 15, 2026
changed the title [-]Share common validation code between the WASM and WASI smoke runners[/-][+]Deduplicate shared validation in the WASM and WASI smoke runners[/+]on Sep 15, 2026
Activity
[-][Proposal]: Share common validation code between the WASM and WASI smoke runners[/-][+]Share common validation code between the WASM and WASI smoke runners[/+][-]Share common validation code between the WASM and WASI smoke runners[/-][+]Deduplicate shared validation in the WASM and WASI smoke runners[/+]