Skip to content

Add unit tests for the WebAssembly smoke runners #643

Closed

Description

@LunaStev

Problem

tools/run_wasm_smoke.mjs and tools/run_wasi_smoke.mjs are currently exercised through the full WebAssembly CI path, but the JavaScript validation logic has no focused unit tests. Small regressions in required exports, private-export rejection, or invalid-module handling therefore require the full compiler smoke job to surface.

Scope

Add lightweight Node tests for the existing smoke-runner behavior. Prefer the built-in node:test module and small generated or checked-in WebAssembly fixtures.

The focused tests should not require a Wave compiler build, LLVM, downloads, or network access. Keep the existing end-to-end WebAssembly smoke jobs.

Completion criteria

  • A valid browser-hosted smoke module is accepted.
  • Missing or invalid required exports are rejected.
  • Leaked __wave_ exports are rejected.
  • Invalid WebAssembly input fails with a nonzero status.
  • A minimal WASI success path is covered where practical.
  • The focused Node tests run in CI without replacing the existing compiler smoke coverage.

Related: #642

Activity

  1. added
    enhancementA request for a new feature or improvement.
    good first issueIssues that are good for newcomers or first-time contributors.
    help wantedThe issue requires extra attention or help from others.
    on Sep 15, 2026
  2. changed the title [-][Proposal]: Add isolated tests for the WebAssembly smoke runner scripts[/-] [+]Add focused tests for the WebAssembly smoke runner scripts[/+] on Sep 15, 2026
  3. added
    needs testingIssues that require additional testing or verification.
    and removed
    enhancementA request for a new feature or improvement.
    on Sep 15, 2026
  4. changed the title [-]Add focused tests for the WebAssembly smoke runner scripts[/-] [+]Add unit tests for the WebAssembly smoke runners[/+] on Sep 15, 2026
  5. self-assigned this
    on Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueIssues that are good for newcomers or first-time contributors.help wantedThe issue requires extra attention or help from others.needs testingIssues that require additional testing or verification.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions