Repository navigation
fix(tools): deduplicate WebAssembly smoke runner validation - #1045
Merged
LunaStev merged 1 commit intoOct 25, 2026
Merged
Conversation
Extract shared module loading and private export validation into tools/wasm_smoke_common.mjs so both run_wasm_smoke.mjs and run_wasi_smoke.mjs use the same export checks without duplicating logic. Signed-off-by: Aman Awasthi <amandeavor@gmail.com>
LunaStev
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract shared WebAssembly module reading and private export validation into \ ools/wasm_smoke_common.mjs\ so both
un_wasm_smoke.mjs\ and
un_wasi_smoke.mjs\ use the same validation logic without duplicated checks.
Motivation
Fixes #642. The private _wave\ export check and module loading were implemented separately across both smoke runners, introducing drift risk.
Target and compatibility impact
None. Command line interfaces and runner behavior remain identical.
Validation
ode --test tools/test_wasm_smoke.mjs\ (11/11 tests pass)
Checklist