Skip to content

fix(tools): deduplicate WebAssembly smoke runner validation - #1045

Merged
LunaStev merged 1 commit into
wavefnd:masterfrom
amandeavor:fix/642-dedup-wasm-smoke-validation
Oct 25, 2026
Merged

LunaStev merged 1 commit into
wavefnd:masterfrom
amandeavor:fix/642-dedup-wasm-smoke-validation

Conversation

@amandeavor

Copy link
Copy Markdown
Contributor

Summary

Extract shared WebAssembly module reading and private export validation into \ ools/wasm_smoke_common.mjs\ so both
un_wasm_smoke.mjs\ and
un_wasi_smoke.mjs\ use the same validation logic without duplicated checks.

Motivation

Fixes #642. The private _wave\ export check and module loading were implemented separately across both smoke runners, introducing drift risk.

Target and compatibility impact

None. Command line interfaces and runner behavior remain identical.

Validation


  • ode --test tools/test_wasm_smoke.mjs\ (11/11 tests pass)

Checklist

  • Commits include a DCO \Signed-off-by\ line.
  • Tests cover new behavior or the PR explains why no test is needed.
  • User-facing changes include documentation or diagnostics updates.
  • The change preserves the license boundary between the compiler and \std/.

Extract shared module loading and private export validation into tools/wasm_smoke_common.mjs so both run_wasm_smoke.mjs and run_wasi_smoke.mjs use the same export checks without duplicating logic.

Signed-off-by: Aman Awasthi <amandeavor@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 25, 2026 06:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@LunaStev
LunaStev merged commit d3758f6 into wavefnd:master Oct 25, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deduplicate shared validation in the WASM and WASI smoke runners

3 participants