Repository navigation
Resolve axis control geometry once per dispatch - #188
Merged
Merged
Conversation
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SplitPaneDispatcherandScrollbarDispatcherresolved the same control geometry inrefresh()and again indispatch(). Each lookup validates the accepted layout, and for a visible control it also projects semantics. Both entry points now use one private reconciliation method. Dispatch uses its returned geometry for the event, skipping the second lookup, and commits the reconciled drag state through the existing candidate copy.Public signatures and object layout are unchanged.
refresh()still returns the canonical pane size or scroll offset. Dispatch retains the same capture eligibility, input diagnostics, and command routing.Verification
split_paneandscrollbarpassed.settings_starterandinspector_hierarchypassed.scripts/format-cpp.ps1 -Check,scripts/check-docs.ps1,cmake -P cmake/release.cmake, andgit diff --checkpassed.