Repository navigation
Finish Replay focus reveal before publishing - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #189–#191, Replay stages layout and paint before installing a replacement view. When a resize or replacement needed to reveal recovered focus,
finish_updatecalled back intosettleand reentered finalization. Command-driven focus also applied the same scroll updates separately.Apply focus reveal offsets through one helper. During finalization, complete the optional second layout and focus recovery in place, then refresh pointers and publish the generation and its semantic observation. This preserves the public API, Replay v1/v2 encoding, focus reveal policy, and the step commit and rollback boundaries.
Candidate review
ReplayPlayer::finish_updatereentered viasettle, andrevealrepeated the offset writes.SplitPaneDispatcher::dispatchandScrollbarDispatcher::dispatchstill have similar move, release and cancellation branches.build_paint_listconverts fill, fallback and opacity within the traversal and emits backend-independent commands.replay_serializationat 27.69 s.Verification
git diff --checkpassed.