Repository navigation
Publish Replay generations with semantic observations - #193
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #192, Replay refreshes pointers against the final layout after focus reveal. It still appended the layout and paint generation before preparing the semantic observation that refers to it.
Prepare the observation against that same settled layout and focus, then publish it with the new generation. Command and focus observations without a new layout continue to refer to the latest generation. Successful recordings retain the same output, diagnostics, public API, and Replay v1/v2 encoding. A semantic projection error after commit still closes the session and leaves the last fully observed generation in
output().Candidate review
ReplayPlayer::finish_updateandobservepublished separate pieces of a generation. #189–#192 already consolidated rollback, view preparation, and focus reveal.build_paint_listconverts background, gradient fallback, and procedural fills during traversal and emits backend-independent commands.replay_serializationtook 33.40 s of the 33.41 s local CTest wall time and includes the production JSON value-limit check.Verification
git diff --checkpassed.