Repository navigation
save: fix remaining macOS and Windows interop checks - #215
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current V master macOS Apps job still rejects the
C.statcall incopy_file_flagsbecause it is outside an unsafe block.PR216 has already migrated the deprecated native-size types and improved concurrent macOS metadata copying. This PR is refreshed onto that merged work and now contains only the remaining save interop corrections.
Change
C.statcall in its requiredunsafeblock.GetFileInformationByHandle's existingosdeclaration with ani32return value, and test it for nonzero success.The refresh preserves PR216's implementation and resolves the branch conflicts. The earlier alias-specific width test and typedef changes are superseded by PR216's native
int/uintmigration; they are no longer part of this PR. Existing upstream save tests are unchanged.Validation
With V master
8636a8fe6c2d285f6bb60ad5686b6ffda61f9835:These checks validate the final refreshed patch. Native macOS and Windows execution was not available; the broader Linux build/test results recorded before this refresh were for the earlier version and are not presented as final-tree runtime validation.
Linux autofree follow-up
The Ubuntu job's generated-C cleanup failure in
draw_text_line_standard_syntaxis a compiler scope-accounting defect, addressed by vlang/v#31766. The unchanged Ved headcd82b857c5e65de987da6ca6633e11240cea3a07now builds natively on Linux with both-new-compiler -autofree -cc gccand-new-compiler -prod -cc gccusing that compiler fix. The compiler PR also includes destruction-order regressions and passes all 11 focused autofree test files. Hosted Linux validation still requires the compiler fix to land.