Repository navigation
transform: preserve autofree scopes around synthetic branches - #31766
Merged
Merged
Conversation
medvednikov
marked this pull request as ready for review
November 3, 2026 06:28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ved's Linux CI compiles successfully in production mode but fails its autofree build with
string__free(&(final))referring to an undeclared local indraw_text_line_standard_syntax(job).Two lowered blocks consume cleanup slots that the checker never recorded as source scopes: the wrapper holding hoisted
else ifcondition statements, and the successful branch of a plain arrayindex or { fallback }lookup. Those extra slots shift later cleanup into earlier branches.Change
Mark these two synthetic blocks with the existing skip-scope-drops mechanism. Their nested source branches and the explicit
orfallback continue to consume their own cleanup slots normally.Add an autofree regression that exercises all membership branches and successful, out-of-bounds, and negative array indices. It checks exact destructor order, fallback destruction only on failure, and a later cloned string whose misplaced cleanup reproduces the C compilation error.
Validation
-new-compiler -autofree -gc none.cd82b857c5e65de987da6ca6633e11240cea3a07pass with both-autofreeand-prod, using GCC and the new compiler.wordbefore its continue andfinalinside its declaring block.git diff --check, and independent source review pass.882c110bfc9595d3b823ef8e8c6813717f9d658aplus exactly these three changed files, matching published headc2fa59572efa59fffbcdf6906189aafd36d9099c. Post-run checks confirmed unchanged source and compiler hashes.This is the compiler-side follow-up for vlang/ved#215.