Skip to content

Add tests from failed attempt at implementing hir::Param move - #166127

Merged
rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:param2
Nov 18, 2026
Merged

rust-bors[bot] merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:param2

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

During the implementation of #163758, we found a lot of bugs this PR introduced during review. I no longer believe we should merge this PR, but lets add regression tests for the bugs!

r? @Kivooeo (or someone else)
cc @ada4a for the clippy changes but I think those are trivial so 🤷

Part of #164357

@rustbot

rustbot commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2026
@JonathanBrouwer JonathanBrouwer changed the title Tests from failed attempt at implementing hir::Param move Add tests from failed attempt at implementing hir::Param move Nov 17, 2026
@Kivooeo

Kivooeo commented Nov 18, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 07c0c12 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 18, 2026
Add tests from failed attempt at implementing `hir::Param` move

During the implementation of rust-lang#163758, we found a lot of bugs this PR introduced during review. I no longer believe we should merge this PR, but lets add regression tests for the bugs!

r? @Kivooeo (or someone else)
cc @ada4a for the clippy changes but I think those are trivial so 🤷

Part of rust-lang#164357
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
Rollup of 16 pull requests

Successful merges:

 - #166037 (reflection: enable tool attributes to be reflectable)
 - #165008 (Support `NonNull` pointers as `asm!` input operands)
 - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k)
 - #166042 (Fix out of scope method suggestion)
 - #166090 (bootstrap: rebuild LLD when LLVM changes)
 - #159795 (Introduce `-Z pack-coroutine-layout` flag)
 - #163556 (arm: only f32 and f64 are valid HFA bases)
 - #164665 (Add Reference annotations for inline assembly)
 - #165725 (change target modifier errors to use the diagnostic APIs instead of structs)
 - #165912 (simplify `fluent_value_from_str_list_sep_by_and`)
 - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`)
 - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain)
 - #166083 (Record seeds in the appropriate order)
 - #166104 (abi/bad-custom.rs: make test run on all editions)
 - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer)
 - #166127 (Add tests from failed attempt at implementing `hir::Param` move)

Failed merges:

 - #165094 (reflection: doc attributes from adts, fields, and variants)
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
…uwer

Rollup of 15 pull requests

Successful merges:

 - #166037 (reflection: enable tool attributes to be reflectable)
 - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k)
 - #166042 (Fix out of scope method suggestion)
 - #166090 (bootstrap: rebuild LLD when LLVM changes)
 - #159795 (Introduce `-Z pack-coroutine-layout` flag)
 - #163556 (arm: only f32 and f64 are valid HFA bases)
 - #164665 (Add Reference annotations for inline assembly)
 - #165725 (change target modifier errors to use the diagnostic APIs instead of structs)
 - #165912 (simplify `fluent_value_from_str_list_sep_by_and`)
 - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`)
 - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain)
 - #166083 (Record seeds in the appropriate order)
 - #166104 (abi/bad-custom.rs: make test run on all editions)
 - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer)
 - #166127 (Add tests from failed attempt at implementing `hir::Param` move)

Failed merges:

 - #165094 (reflection: doc attributes from adts, fields, and variants)
@rust-bors
rust-bors Bot merged commit abceb21 into rust-lang:main Nov 18, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 18, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
Rollup merge of #166127 - JonathanBrouwer:param2, r=Kivooeo

Add tests from failed attempt at implementing `hir::Param` move

During the implementation of #163758, we found a lot of bugs this PR introduced during review. I no longer believe we should merge this PR, but lets add regression tests for the bugs!

r? @Kivooeo (or someone else)
cc @ada4a for the clippy changes but I think those are trivial so 🤷

Part of #164357
yermakoffivan pushed a commit to yermakoffivan/rust-clippy that referenced this pull request Nov 20, 2026
…uwer

Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#166037 (reflection: enable tool attributes to be reflectable)
 - rust-lang/rust#165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k)
 - rust-lang/rust#166042 (Fix out of scope method suggestion)
 - rust-lang/rust#166090 (bootstrap: rebuild LLD when LLVM changes)
 - rust-lang/rust#159795 (Introduce `-Z pack-coroutine-layout` flag)
 - rust-lang/rust#163556 (arm: only f32 and f64 are valid HFA bases)
 - rust-lang/rust#164665 (Add Reference annotations for inline assembly)
 - rust-lang/rust#165725 (change target modifier errors to use the diagnostic APIs instead of structs)
 - rust-lang/rust#165912 (simplify `fluent_value_from_str_list_sep_by_and`)
 - rust-lang/rust#165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`)
 - rust-lang/rust#166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain)
 - rust-lang/rust#166083 (Record seeds in the appropriate order)
 - rust-lang/rust#166104 (abi/bad-custom.rs: make test run on all editions)
 - rust-lang/rust#166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer)
 - rust-lang/rust#166127 (Add tests from failed attempt at implementing `hir::Param` move)

Failed merges:

 - rust-lang/rust#165094 (reflection: doc attributes from adts, fields, and variants)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants