Repository navigation
Add tests from failed attempt at implementing hir::Param move - #166127
Merged
Merged
Conversation
Collaborator
|
cc @rust-lang/clippy |
hir::Param movehir::Param move
6 tasks
Kivooeo
approved these changes
Nov 17, 2026
Member
|
@bors r+ rollup |
Contributor
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 18, 2026
Add tests from failed attempt at implementing `hir::Param` move During the implementation of rust-lang#163758, we found a lot of bugs this PR introduced during review. I no longer believe we should merge this PR, but lets add regression tests for the bugs! r? @Kivooeo (or someone else) cc @ada4a for the clippy changes but I think those are trivial so 🤷 Part of rust-lang#164357
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Rollup of 16 pull requests Successful merges: - #166037 (reflection: enable tool attributes to be reflectable) - #165008 (Support `NonNull` pointers as `asm!` input operands) - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k) - #166042 (Fix out of scope method suggestion) - #166090 (bootstrap: rebuild LLD when LLVM changes) - #159795 (Introduce `-Z pack-coroutine-layout` flag) - #163556 (arm: only f32 and f64 are valid HFA bases) - #164665 (Add Reference annotations for inline assembly) - #165725 (change target modifier errors to use the diagnostic APIs instead of structs) - #165912 (simplify `fluent_value_from_str_list_sep_by_and`) - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`) - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain) - #166083 (Record seeds in the appropriate order) - #166104 (abi/bad-custom.rs: make test run on all editions) - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer) - #166127 (Add tests from failed attempt at implementing `hir::Param` move) Failed merges: - #165094 (reflection: doc attributes from adts, fields, and variants)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
…uwer Rollup of 15 pull requests Successful merges: - #166037 (reflection: enable tool attributes to be reflectable) - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k) - #166042 (Fix out of scope method suggestion) - #166090 (bootstrap: rebuild LLD when LLVM changes) - #159795 (Introduce `-Z pack-coroutine-layout` flag) - #163556 (arm: only f32 and f64 are valid HFA bases) - #164665 (Add Reference annotations for inline assembly) - #165725 (change target modifier errors to use the diagnostic APIs instead of structs) - #165912 (simplify `fluent_value_from_str_list_sep_by_and`) - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`) - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain) - #166083 (Record seeds in the appropriate order) - #166104 (abi/bad-custom.rs: make test run on all editions) - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer) - #166127 (Add tests from failed attempt at implementing `hir::Param` move) Failed merges: - #165094 (reflection: doc attributes from adts, fields, and variants)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Rollup merge of #166127 - JonathanBrouwer:param2, r=Kivooeo Add tests from failed attempt at implementing `hir::Param` move During the implementation of #163758, we found a lot of bugs this PR introduced during review. I no longer believe we should merge this PR, but lets add regression tests for the bugs! r? @Kivooeo (or someone else) cc @ada4a for the clippy changes but I think those are trivial so 🤷 Part of #164357
yermakoffivan
pushed a commit
to yermakoffivan/rust-clippy
that referenced
this pull request
Nov 20, 2026
…uwer Rollup of 15 pull requests Successful merges: - rust-lang/rust#166037 (reflection: enable tool attributes to be reflectable) - rust-lang/rust#165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k) - rust-lang/rust#166042 (Fix out of scope method suggestion) - rust-lang/rust#166090 (bootstrap: rebuild LLD when LLVM changes) - rust-lang/rust#159795 (Introduce `-Z pack-coroutine-layout` flag) - rust-lang/rust#163556 (arm: only f32 and f64 are valid HFA bases) - rust-lang/rust#164665 (Add Reference annotations for inline assembly) - rust-lang/rust#165725 (change target modifier errors to use the diagnostic APIs instead of structs) - rust-lang/rust#165912 (simplify `fluent_value_from_str_list_sep_by_and`) - rust-lang/rust#165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`) - rust-lang/rust#166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain) - rust-lang/rust#166083 (Record seeds in the appropriate order) - rust-lang/rust#166104 (abi/bad-custom.rs: make test run on all editions) - rust-lang/rust#166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer) - rust-lang/rust#166127 (Add tests from failed attempt at implementing `hir::Param` move) Failed merges: - rust-lang/rust#165094 (reflection: doc attributes from adts, fields, and variants)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the implementation of #163758, we found a lot of bugs this PR introduced during review. I no longer believe we should merge this PR, but lets add regression tests for the bugs!
r? @Kivooeo (or someone else)
cc @ada4a for the clippy changes but I think those are trivial so 🤷
Part of #164357