Repository navigation
Support for register load/store instructions and bug fixes - #32
Open
ElioPalleschi wants to merge 8 commits into
Open
ElioPalleschi wants to merge 8 commits into
ElioPalleschi wants to merge 8 commits into
Conversation
vl<nf>re<eew>.v and vs<nf>r.v and bug fixes
vl<nf>re<eew>.v and vs<nf>r.v and bug fixes
ElioPalleschi
marked this pull request as ready for review
October 29, 2026 09:51
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
rgiunti
self-requested a review
October 29, 2026 13:05
rgiunti
approved these changes
Oct 29, 2026
rgiunti
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @ElioPalleschi, it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the
vl<nf>re<eew>.vandvs<nf>r.vinstructions and fixes tovfredosum.v,vmv.x.s,vadc.v,vmadc.v,vsbc.vandvmsbc.v. After the synthesis, the new vpu module's area has increased by 0.5%.These changes are verified by the tests introduced by this PR.
Support for
vl<nf>re<eew>.vandvs<nf>r.vAdded decoding, control, and execution support for the
VLRE(VL1RE8_V,VL2RE8_V, etc.) andVSR(VS1R_V,VS2R_V, etc.) instructions. They are handled by converting them into equivalent flat, unmasked, unit-stride byte transfers.vfredosum.vfixBefore this change, vfredosum was executed as a parallel tree, like vfredusum.
vmv.x.sfixOriginally, the VFU simply copied the entire lower word of a vector register into the scalar register without extracting element 0 or sign-extending it to XLEN according to the active element width.
is_int_scalar_moveto theop_arithstruct to differentiate it from other scalar-producing operations, and set it to 1 forvmv.x.s.scalar_resultassignment to adapt it forvmv.x.s.vadc.v,vmadc.v,vsbc.v,vmsbc.vfixThese instructions didn't use the carry-in, and instead treated v0 as a write mask.