Skip to content

libnpmexec: escape executable name on Windows (cmd injection via npx) #10095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalt2212 wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

libnpmexec: escape executable name on Windows (cmd injection via npx) #10095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions workspaces/libnpmexec/lib/run-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ const run = async ({
// literally; double quotes still expand $(), backticks, $var and "
args[0] = `'${args[0].replace(/'/g, `'\\''`)}'`
}
} else if (args.length > 0) {
// cmd.exe: double-quote so & | < > ^ are taken literally; %VAR% still
// expands inside quotes, so double %; "" is cmd's quoted literal for ".
args[0] = `"${args[0].replace(/%/g, '%%').replace(/"/g, '""')}"`
}

// turn list of args into command string
Expand Down