Repository navigation
Conversation
Commit 6901bb1 escaped the executable name for non-Windows shells but left the Windows branch raw: a malicious bin entry (e.g. "x&calc") reaches cmd.exe /d /s /c unescaped, allowing arbitrary command execution as the user on npx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 6901bb1 escaped the executable name in libnpmexec run-script for non-Windows shells, but the Windows branch was left raw. A package with a malicious bin entry (e.g. "x&calc") reaches cmd.exe /d /s /c unescaped when the victim runs npx on Windows -- cmd.exe interprets &, |, <, > and %VAR%, giving arbitrary command execution as the user (CWE-78).
This mirrors the existing non-Windows escaping for the Windows branch: double-quote the name (so & | < > ^ are literal), double % (still expands inside quotes) and use "" for embedded quotes.
Static end-to-end trace verified; preflight clean (no existing issue/CVE for this pattern).