Repository navigation
Keep Basic auth header when username or password is empty - #8151
Open
adityav1709 wants to merge 2 commits into
Open
adityav1709 wants to merge 2 commits into
adityav1709 wants to merge 2 commits into
Conversation
Signed-off-by: adityav1709 <adityav170920@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1AbdullahButt
left a comment
There was a problem hiding this comment.
Looks correct. Here's what I checked.
- These are the only two Basic header builders. Searching
src/google/adkforBasicand forcredentials.usernamefinds onlyauth/_auth_headers.py:65-78andtools/mcp_tool/mcp_tool.py:973-980. The OpenAPI/REST tools build their headers throughbuild_auth_headers, so they're covered by the first change. Nonestill means "no usable credential".HttpCredentials.username/passworddefault toNone, soHttpCredentials()and the username-only or password-only cases still return no header, which the six new cases pin. An empty string now encodes as expected:base64("api-key:"),base64(":pass")andbase64(":")match RFC 7617, where the password may be empty.- Raw tokens still can't be used for Basic.
auth_handler.py:83-87still raises for a raw token string with thebasicscheme, so this doesn't open a path that sendsNone:None. - Redaction still works.
auth_handler.py:110setspassword = Noneon the redacted copy, so a redacted credential still gives no header instead ofuser:.
I didn't run the tests.
Reviewed with help from Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpCredentials permits an empty username or password, but the Basic-auth header builders used truthiness checks, silently dropping the Authorization header. This keeps the Basic auth header when the username or password is empty (checks is not None instead of truthiness).
Fixes #8139.
Supersedes #8145 — same fix, clean commit without the co-author line to satisfy the Google CLA.