Skip to content

Keep Basic auth header when username or password is empty - #8151

Open
adityav1709 wants to merge 2 commits into
google:mainfrom
adityav1709:fix/8139-basic-auth-empty-credentials-v2
Open

adityav1709 wants to merge 2 commits into
google:mainfrom
adityav1709:fix/8139-basic-auth-empty-credentials-v2

Conversation

@adityav1709

Copy link
Copy Markdown

HttpCredentials permits an empty username or password, but the Basic-auth header builders used truthiness checks, silently dropping the Authorization header. This keeps the Basic auth header when the username or password is empty (checks is not None instead of truthiness).

Fixes #8139.

Supersedes #8145 — same fix, clean commit without the co-author line to satisfy the Google CLA.

Signed-off-by: adityav1709 <adityav170920@gmail.com>
@google-cla

google-cla Bot commented Nov 14, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@1AbdullahButt 1AbdullahButt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Here's what I checked.

  • These are the only two Basic header builders. Searching src/google/adk for Basic and for credentials.username finds only auth/_auth_headers.py:65-78 and tools/mcp_tool/mcp_tool.py:973-980. The OpenAPI/REST tools build their headers through build_auth_headers, so they're covered by the first change.
  • None still means "no usable credential". HttpCredentials.username/password default to None, so HttpCredentials() and the username-only or password-only cases still return no header, which the six new cases pin. An empty string now encodes as expected: base64("api-key:"), base64(":pass") and base64(":") match RFC 7617, where the password may be empty.
  • Raw tokens still can't be used for Basic. auth_handler.py:83-87 still raises for a raw token string with the basic scheme, so this doesn't open a path that sends None:None.
  • Redaction still works. auth_handler.py:110 sets password = None on the redacted copy, so a redacted credential still gives no header instead of user:.

I didn't run the tests.

Reviewed with help from Claude Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic HTTP auth drops credentials with empty username or password

3 participants