Repository navigation
Keep Basic auth header when username or password is empty - #8145
Closed
adityav1709 wants to merge 1 commit into
Closed
adityav1709 wants to merge 1 commit into
adityav1709 wants to merge 1 commit into
Conversation
HttpCredentials permits an empty username or password, but the Basic auth header builders used truthiness checks, so they silently dropped the Authorization header, for example when an API key is used as the username with an empty password. Check for None instead of truthiness, matching the OpenAPI auth helper which already does this. Fixes google#8139 Signed-off-by: adityav1709 <adityav170920@gmail.com> Co-authored-by: Muse (Aurora)
Author
|
Author
|
Superseded by #8151 — same fix, clean commit without the co-author line to satisfy the Google CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpCredentials permits an empty username or password, but the Basic auth header builders used truthiness checks, so they silently dropped the Authorization header, for example when an API key is used as the username with an empty password. This change checks for None instead of truthiness, matching the OpenAPI auth helper which already does this. Adds regression tests. Fixes #8139. Built with Muse (Aurora) as co-author.