Skip to content

fix: honor zero optimizer runs during bytecode verification #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omerbek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: honor zero optimizer runs during bytecode verification #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/hardhat/verifyOnChainBytecode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export async function verifyOnChainBytecode(
}: TaskArguments,
hre: HardhatRuntimeEnvironment
): Promise<BytecodeComparisonResult[]> {
if (optimizerRuns) {
if (optimizerRuns !== undefined) {
validateOptimizerRuns(optimizerRuns);
execSyncWrapper(`forge build --optimizer-runs ${optimizerRuns}`);
}
Expand Down
23 changes: 23 additions & 0 deletions test/scripts/hardhat/verifyOnChainBytecode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,29 @@ describe("Verify on chain bytecode", () => {
).to.be.true;
});

it("will execute the expected forge command when optimizerRuns is zero", async () => {
const results = await verifyOnChainBytecode(
{
contractName: "FiatTokenProxy",
contractAddress: await opMainnetArtifactFiatTokenProxy.getAddress(),
verificationType: BytecodeVerificationType.Partial,
artifactType: ArtifactType.OPMainnet,
optimizerRuns: 0,
},
hre
);

expect(results).to.deep.equal([
{ type: BytecodeInputType.RuntimeBytecodePartial, equal: true },
]);

expect(
execSyncWrapperStub.calledOnceWithExactly(
"forge build --optimizer-runs 0"
)
).to.be.true;
});

it("Can detect mismatched metadata input", async () => {
const results = await verifyOnChainBytecode(
{
Expand Down