Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimizerRuns: 0as a provided value instead of falling through the truthy guardforge build --optimizer-runs 0to runFixes #677.
Testing
corepack yarn --ignore-engines hardhat test test/scripts/hardhat/verifyOnChainBytecode.test.ts --grep "optimizerRuns is zero"corepack yarn --ignore-engines prettier scripts/hardhat/verifyOnChainBytecode.ts test/scripts/hardhat/verifyOnChainBytecode.test.ts --checkNote: this local Windows environment has Node v21.6.1 while the repo pins Node 20.18.0, so I used
--ignore-engines. The full file test also requires a real Foundryforge buildto generate Foundry artifacts; for this focused regression I used the existing staticArtifactType.OPMainnetpath and a tempforgestub only for the hardhat-foundry startup checks.