Repository navigation
Allow disabling cellular recording while keeping app-call recording enabled - #966
Closed
jerechinsky wants to merge 1 commit into
Closed
jerechinsky wants to merge 1 commit into
jerechinsky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCR currently records cellular calls whenever its main recording switch is on. This prevents using another recorder for cellular calls while keeping BCR enabled for calls from telecom-integrated apps.
Add a separate Record cellular calls switch, defaulting to on to preserve existing behavior. When disabled, calls associated with
com.android.phoneare rejected before a recorder thread or audio capture is created. The existing third-party-call switch stays independent, and the main recording switch remains the master control. Missing source information is ignored rather than risking concurrent recording.Related to #885. This is a small independent-toggle alternative to adding source-app conditions to recording rules.
Validation:
:app:testDebugUnitTestpasses against current master. The policy test covers all four switch combinations for cellular calls, Meet, another app, and missing/empty sources (20 assertions).The local deployment uses a separate app identity for rollback and migration. Those deployment-specific changes are not included in this PR.