Repository navigation
Add source app conditions to recording rules - #967
Closed
jerechinsky wants to merge 1 commit into
Closed
jerechinsky wants to merge 1 commit into
jerechinsky wants to merge 1 commit into
Conversation
Author
|
Sorry, I just noticed AI-generated content isn’t permitted. I’m closing both PRs. Sorry if I wasted your time. |
Owner
No worries! If I end up implementing this and it's sufficiently similar to your approach, I'll include you as co-author on the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the extra PR. I really wanted to keep BCR for app calls while using Google Phone for cellular calls, so I asked Codex to put together an alternative to #966 using the source-app rules you suggested in #885.
This adds a Source app condition to the existing rules. For my setup, I can put “Cellular calls → Ignore” above the default save rule. Individual apps can also be selected, and existing rules keep matching any source.
Both PRs were vibe-coded with Codex and tested on my Pixel. For this version, I also checked it with live calls: Meet recorded successfully, and BCR ignored a connected cellular call without starting audio capture. No hard feelings if you tear the code apart or close either PR if it’s not the direction you want to take.
Test device: Pixel 10a, Android 17. I also checked the source picker on the phone. Debug and release builds, lint, and local tests for rule ordering, combined conditions and old-settings compatibility passed.