Repository navigation
Fix is_plan_node() for PartitionSelector and non-Plan nodes - #2269
Merged
tuhaihe merged 1 commit intoNov 9, 2026
Merged
Conversation
is_plan_node() checks that the node tag lies in the range T_Plan_Start..T_Plan_End, with T_Plan_End defined as T_PlanRowMark. Since node tags are generated by gen_node_support.pl, in the order the structs appear in plannodes.h, that range is no longer exact: - PartitionSelector is defined after PlanRowMark, so it is not considered a Plan node, although its first field is a Plan. - ExternalScanInfo and NestLoopParam are defined among the Plan nodes, so they are considered Plan nodes, although they are not. Missing PartitionSelector makes the walkers that rely on is_plan_node() skip it, and some of them, like shareinput_walker(), its whole subtree. A Shared Scan below a Partition Selector is then not set up, and the query fails, e.g.
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_plan_node() checks that the node tag lies in the range T_Plan_Start..T_Plan_End, with T_Plan_End defined as T_PlanRowMark. Since node tags are generated by gen_node_support.pl, in the order the structs appear in plannodes.h, that range is no longer exact:
Missing PartitionSelector makes the walkers that rely on is_plan_node() skip it, and some of them, like shareinput_walker(), its whole subtree. A Shared Scan below a Partition Selector is then not set up, and the query fails, e.g.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions