Skip to content

[Bug] Correct classification of plan nodes #2268

Open

Description

@lss602726449

Apache Cloudberry version

main

What happened

Some nodes that are not plan nodes have been incorrectly categorized as plan nodes, while some actual plan nodes have failed to be classified as such. We need to categorize these nodes correctly; otherwise, it could lead to issues regarding the correctness of serialization. What follows may not be exhaustive.

diff --git a/src/backend/cdb/cdbllize.c b/src/backend/cdb/cdbllize.c
index 31749f0305b..b4bdf5bf863 100644
--- a/src/backend/cdb/cdbllize.c
+++ b/src/backend/cdb/cdbllize.c
@@ -1430,6 +1430,24 @@ is_plan_node(Node *node)
 	if (node == NULL)
 		return false;
 
+	/*
+	 * Node tags are generated in the order the structs appear in
+	 * plannodes.h, so the T_Plan_Start..T_Plan_End range is not exact:
+	 * NestLoopParam and ExternalScanInfo are defined among the plan nodes
+	 * but are not Plans, and PartitionSelector is defined after
+	 * PlanRowMark but is one.
+	 */
+	switch (nodeTag(node))
+	{
+		case T_NestLoopParam:
+		case T_ExternalScanInfo:
+			return false;
+		case T_PartitionSelector:
+			return true;
+		default:
+			break;
+	}
+
 	if (nodeTag(node) >= T_Plan_Start && nodeTag(node) < T_Plan_End)
 		return true;
 	return false;

What you think should happen instead

No response

How to reproduce

Cannot be exhaustively listed

Operating System

NAME="Rocky Linux" VERSION="9.5 (Blue Onyx)"

Anything else

No response

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Activity

  1. allenvox commented on Nov 12, 2026

    @allenvox
    Contributor

    Probably already fixed in #2269 (merged), is_plan_node() now excludes ExternalScanInfo and NestLoopParam and includes PartitionSelector, commit also adds a regression case in shared_scan.sql covering a Shared Scan below a Partition Selector.

    Does this fully address the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: BugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions