Skip to content

GH-46439: [C++] Rename internal Converter class in from_string.cc - #46697

Merged
kou merged 1 commit into
apache:mainfrom
amoeba:fix/GH-46439--post-merge-expose-fromjson--rename-converter
Jun 3, 2025
Merged

kou merged 1 commit into
apache:mainfrom
amoeba:fix/GH-46439--post-merge-expose-fromjson--rename-converter

Conversation

@amoeba

@amoeba amoeba commented Jun 3, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

In #45908 we moved the Converter class in from_string.cc to the internal namespace to avoid a symbol clash with the Converter class defined in arrow/util. It's better to keep the class in an anonymous namespace since it's internal to the file. This reverts the previous change and just renames the class.

What changes are included in this PR?

  • Removed namespace, use anonymous namespace instead like before
  • Renamed from Converter to JSONConverter

Are these changes tested?

Yes.

Are there any user-facing changes?

No. These changes are internal-only.

@kou kou changed the title GH-46439: [C++]: Rename internal Converter class in from_string.cc GH-46439: [C++] Rename internal Converter class in from_string.cc Jun 3, 2025

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit fbed20a into apache:main Jun 3, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fbed20a.

There were 70 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants