Skip to content

[C++] Address post-merge review comments in PR exposing {Array,...}FromJSON helpers in public API #46439

Closed

Description

@amoeba

Describe the enhancement requested

#46180 was just merged to resolve #45908 and @pitrou left three comments after it was merged. Comments linked below:

I'll reply to each in their place, update this issue with what changes we decided on, and file a PR to resolve them.

Component(s)

C++

Activity

  1. self-assigned this
    on May 14, 2025
  2. changed the title [-][C++] Address post-merge review comments exposing {Array,...}FromJSON helpers in public API[/-] [+][C++] Address post-merge review comments in PR exposing {Array,...}FromJSON helpers in public API[/+] on May 14, 2025
  3. amoeba commented on May 14, 2025

    @amoeba
    MemberAuthor

    I've dropped comments in their respective locations in the above links. I may split this up into three PRs but currently have a draft up at #46447.

  4. added this to the 21.0.0 milestone on Jun 3, 2025
  5. kou commented on Jun 3, 2025

    @kou
    Member

    Issue resolved by pull request 46695
    #46695

  6. added a commit that references this issue on Jun 3, 2025
  7. added a commit that references this issue on Jun 3, 2025
  8. added a commit that references this issue on Jun 5, 2025
  9. added a commit that references this issue on Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions