You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++] Address post-merge review comments in PR exposing {Array,...}FromJSON helpers in public API #46439
changed the title [-][C++] Address post-merge review comments exposing {Array,...}FromJSON helpers in public API[/-][+][C++] Address post-merge review comments in PR exposing {Array,...}FromJSON helpers in public API[/+]on May 14, 2025
Activity
[-][C++] Address post-merge review comments exposing {Array,...}FromJSON helpers in public API[/-][+][C++] Address post-merge review comments in PR exposing {Array,...}FromJSON helpers in public API[/+]amoeba commentedon May 14, 2025
I've dropped comments in their respective locations in the above links. I may split this up into three PRs but currently have a draft up at #46447.
amoeba commentedon Jun 3, 2025
I put up three PRs to fix each of the comments,
kou commentedon Jun 3, 2025
Issue resolved by pull request 46695
#46695
GH-46439: [C++] Rename internal Converter class in from_string.cc (#4…
apacheGH-46439: [C++] Remove unneeded namespace prefix in test_util_i…
GH-46439: [C++] Use result pattern for all FromJSONString Helpers (#4…
apacheGH-46439: [C++] Use result pattern for all FromJSONString Helpe…