Repository navigation
Move Polls and Tasks to side panels, and their editors to windows - #1668
Merged
Merged
Conversation
Polls and Tasks open as wide side panels with the pin; Create poll becomes an icon in the header, and Tasks keeps its Announcements and Tasks sections through the new sections option. Their bottom Close buttons go. The poll, task and announcement editors become draggable windows with an X next to their own buttons, wide enough for the vanilla dialog buttons they now use, and they stay open when the panel closes, so pinning it doesn't lose a draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Few issues I'd like to check with you Polls
New poll
Tasks
Create Task, Edit Announcement
I know docked windows can be toggled with toolbar respective button, but for the sake of consistency, I'd choose these rules:
|
From review: every window, docked or not, has its own X and no Close button. Polls is as wide as its contents and shows the time left short. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks, all done in 8958da3, with new screenshots in the description:
The next PR (the dialog button rows) follows the same rule: no Close button, the X closes. |
RedRafe
reviewed
Oct 30, 2026
lex
added a commit
to lex/RedMew
that referenced
this pull request
Oct 30, 2026
From Refactorio#1668's review: every panel and window has its own X and no Close or Cancel button, so Settings drops Cancel. docs/GUI.md says so, describes panel footers and the dialog buttons' defaults, and asks for styles to be set with Gui.set_style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lex
added a commit
to lex/RedMew
that referenced
this pull request
Nov 1, 2026
From Refactorio#1668's review: every panel and window has its own X and no Close or Cancel button, so Settings drops Cancel. docs/GUI.md says so, describes panel footers and the dialog buttons' defaults, and asks for styles to be set with Gui.set_style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lex
added a commit
to lex/RedMew
that referenced
this pull request
Nov 2, 2026
From Refactorio#1668's review: every panel and window has its own X and no Close or Cancel button, so Settings drops Cancel. docs/GUI.md says so, describes panel footers and the dialog buttons' defaults, and asks for styles to be set with Gui.set_style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polls and Tasks move to the side panel layout from #1662, like Experience, Tag group and Players in #1663: a header with the panel's title, a pin that floats it into a window you can drag anywhere and docks it back, and an X. Their editors become windows of their own.
Change
features/gui/poll.lua: Polls is a side panel as wide as its contents. Create poll becomes a + icon in the header, beside the pin, and the bottom row with Close and Create poll goes. The time left is short (9m 56s, was 9 minutes 56 seconds), and Notify me about polls goes in a footer (screenshot 1). The poll editor (new poll and edit poll) is a draggable window closed by its X: Clear on the left, Create poll as the green confirm on the right (screenshot 2).features/gui/tasklist.lua: Tasks is a wide side panel titled Tasks, keeping its Announcements and Tasks sections, each with its own subheader and edit or + button. The Close button goes, and the notify checkbox goes in a footer (screenshot 3). The task editor and the announcements editor are draggable windows closed by their X, with the same buttons (screenshots 4 and 5); the announcements editor is at least as wide as the panel.features/gui/tag_group.lua: the tag editor from Move Experience, Tag group and Players to the side panel header #1663 loses its Close button too, so it's closed by its X like the others.utils/gui.lua,Gui.add_panel:sections = truefor a panel made of sections, each an inner frame with its own subheader: it gets a flow to add them to instead of the padded inner frame, so the sections don't sit in a second frame;footer = trueadds a footer (Factorio'ssubfooter_frame) along the bottom of the inner frame, or under the sections, and returns it.tasklist.frame_title(Tasks), the panel's title, in every language.The rule from review: every window, docked or not, has its own X, and no Close button.
Clear and Reset are still plain buttons, shorter than the confirm button beside them. The next PR in this series lays out every dialog's button row the same way with one helper (secondary buttons in the dialog style at the same height, confirm on the right), so this one leaves them as they are.
Tests
utils/gui_tests.lua: a docked panel has an X, and the X closes it; a footer sits along the bottom of the inner frame, under the content; with sections, it sits under them.utils/Guitests with a player, in a 2.1.24 client: 28 passed, 0 failed.pwsh .github/scripts/run-all.ps1 <factorio> crashsite danger-ore diggy frontier: all pass.luacheck .: 0 warnings / 0 errors.Screenshots
🤖 Generated with Claude Code