Repository navigation
Conversation
Gui.add_dialog puts a window's content in a padded inner frame, and Gui.add_dialog_buttons adds the row of buttons below it: the likes of Clear on the left, the confirming button on the right, space to drag the window by between them, and all of them the same height. A dialog has no Close or Cancel button: its X closes it. The poll, task, announcement and tag editors, the report form, the jail confirmation and popups use them. A window whose only button was Close now closes with its X alone. Docked panels keep their size when they don't all fit, and the announcements in Tasks read as text rather than an input field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Polls and Tasks drop their own STYLES buttons for vanilla tool_button and tool_button_red, page with arrow icons, and show the player's own vote or volunteering as a lit button rather than an orange number. The production HUD's header buttons are frame_action_buttons like every other panel's. docs/GUI.md says where a GUI goes, how it closes and which element does each job, and AGENTS.md points to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The narrow width left an empty strip on the right of its inner frame, since nothing in it stretches. The instructions label gets its own width instead, as a wrapping label needs one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shortcuts drops the inner frame and puts its buttons on the game's shortcut bar slots, through a new frameless option for Gui.add_panel. Choose your tag's list fills its inner frame without a border of its own, with the notify checkbox in a footer under it. Autofill's rows go in a spaced table, so the ammo slots' border no longer covers the ammo count field. Paint's brush is a plain slot-sized button, without the extra flow and sunken frame around it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It opens through Gui.add_window, so it has an X and remembers where it was left, and its Cancel and Save changes buttons go in Gui.add_dialog_buttons' row with space to drag it by between them. Fraction settings such as the toast volume show their percentage next to the slider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Player list headings are caption_labels, Poke and Report tool_buttons. The production HUD picks its time span from a drop-down, shows production and consumption as plain numbers with the game's own tooltips, and adds items and fluids through filtered pickers instead of a signal picker. Shortcuts and Experience drop their font colours and fake slot buttons, Paint keeps its instructions in the brush's tooltip, the tag list's buttons are tool_buttons, and Gui.make_close_button is a plain back_button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The brush's tooltip already says a right click clears it, so the panel drops its trash button and is just the brush. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Like the other top buttons, Paint shows refined hazard concrete and Shortcuts a selector combinator instead of the game's flat interface icons, here and in the info window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From Refactorio#1668's review: every panel and window has its own X and no Close or Cancel button, so Settings drops Cancel. docs/GUI.md says so, describes panel footers and the dialog buttons' defaults, and asks for styles to be set with Gui.set_style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The brush is a sunken slot like the game's own, named beside it ("Select
brush tile" while empty), with the instructions back under it, reworded
in every language. Its tooltip keeps only the tile and the right click.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The selector combinator meant nothing for Shortcuts: the full-color hand is the one the button had before, in color. Tag group's dark bookmark becomes the map's tag marker, while the player has no tag of their own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
A few feedbacks: Polls
Tip: should show in screenshot the version where player has voted at least an option, and multiple options and show arrow buttons both enabled and disabled Announcements\Tasks
Stats
Paint brush
Additionally, show in the button tooltip how to clear it Shortcuts
Autofill
Player list
Choose your tag
Additionally, edit button is not visible to non-admin, so different styles for the 2 buttons is not an issue for players. Settings
Additionally, this part could be standardized as any other Gui.panel (both docked & free able) now. Tool bar
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The side panels and the Settings window use Factorio's own elements for each job instead of custom styles and font colours, and
docs/GUI.mdwrites down how RedMew builds its GUIs, so the next one fits in: where a GUI goes, how it closes, which element does which job, and what's easy to get wrong.This builds on #1669 (dialog buttons), whose commit is at the start of this branch until that merges.
Change
docs/GUI.md, a new guide, andAGENTS.mdpoints to it. It includes the rules from Move Polls and Tasks to side panels, and their editors to windows #1668's review: every panel and window has its own X and no Close or Cancel button (the info window, the first one new players see, keeps its Close as the one exception), and styles are set withGui.set_style.tool_buttons with arrow icons, the question is abold_label, and the player's own vote shows as a lit button rather than an orange number.tool_buttons (tool_button_redto delete), and the player's own volunteering is a lit button.frame_action_buttons like every other panel's.framelessoption forGui.add_panel, without font colours.caption_labels, Poke and Report aretool_buttons, and the names line up with the buttons.tool_buttons.Gui.add_window, so it has an X and remembers where it was left; Save changes goes inGui.add_dialog_buttons' row and Cancel goes (its locale key too). Fraction settings such as the toast volume show their percentage next to the slider.bold_labels rather than fake slot buttons.Gui.make_close_buttonis a plainback_button, andresources/styles.lualoses the styles nothing uses any more.Tests
utils/Guitests with a player, in a 2.1.24 client: 28 passed, 0 failed.pwsh .github/scripts/run-all.ps1 <factorio> crashsite danger-ore diggy frontier: all pass.luacheck .: 0 warnings / 0 errors.Screenshots
🤖 Generated with Claude Code