Repository navigation
Fix check.bety.version unknown-migration check - #4155
Open
madhavzanwar wants to merge 2 commits into
Open
madhavzanwar wants to merge 2 commits into
madhavzanwar wants to merge 2 commits into
Conversation
any() was called on a character vector of unknown migration versions, which raised a coercion warning and then failed with 'missing value where TRUE/FALSE needed' instead of emitting the intended warning. Test the length of the vector instead, and add tests.
Contributor
Author
|
Hi @infotroph, could you review this when you have a moment? It fixes #4165: The workflows on this fork PR are showing "Action required", so CI hasn't run yet. |
Contributor
Author
|
@infotroph same for this one: a small fix for #4165 (check.bety.version errored instead of warning about unknown database migrations), with a test. |
Resolve the base/settings/NEWS.md conflict by keeping both entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the migration version check to avoid using
any()on character vectors containing unknown migration versions.Previously, this caused a coercion warning followed by a
missing value where TRUE/FALSE needederror instead of the expected warning.The logic now checks the length of the migration version vector directly, allowing unknown versions to be handled safely.
Added tests to verify the correct warning behavior and ensure the function does not fail unexpectedly.