Skip to content

check.bety.version() errors instead of warning about unknown database migrations #4165

Open

Description

@madhavzanwar

check.bety.version() (base/settings/R/check.all.settings.R) calls any(unknown_migrations) on a character vector. When the database has a migration this release doesn’t know, R warns about coercing character to logical, then if (NA) fails with “missing value where TRUE/FALSE needed”. The intended warning never appears. Fix: test length(unknown_migrations) > 0. Reproduce by mocking db.query to return the known versions plus one extra.

I have a PR with tests: #4155.

Activity

  1. madhavzanwar commented on Oct 17, 2026

    @madhavzanwar
    ContributorAuthor

    please review this issue and the pr linked with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions