Repository navigation
Conversation
The Terms listing lacked the settings cog present on the Books and Bookmarks listings. Add the shared datatables config widget (the gear icon) with a column-visibility (colvis) control scoped to the content columns, and move the page-length and button controls into it, matching the existing Books/Bookmarks pattern. Fixes #315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315.
What
The Terms listing lacked the settings cog that the Books and Bookmarks listings already have. This adds the same datatables config widget (the gear icon) to the Terms page, giving:
How
Mirrors the existing Books/Bookmarks implementation:
#datatables_config_widget(gear) and#datatables_config_itemsmarkup.colvisbutton to the terms datatable, scoped to the content columns (excludes the row-select checkbox and the hidden TermID/LanguageID columns).move_datatables_controls_to_config_widgethelper and the gear toggle.The existing Export CSV button (triggered from the Actions menu) now also lives inside the config widget, consistent with how the Books page surfaces its buttons.
Testing
Verified end-to-end with Playwright against the running app: the gear toggles the config popup, the colvis control lists the 7 content columns and hides/shows them, and there are no JS console errors.