Repository navigation
Conversation
Since e21138a ("Use new js library"), DictButton._load_popup builds lookup_url (with [LUTE] replaced by the term) but passes the raw dict url to LutePopups.open_popup, so popup dictionaries search for the literal "[LUTE]" (e.g. Forvo 404s, japandict searches "[lute]"). Pass lookup_url instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The popup tests only counted windows, so they missed popups opening the raw "[LUTE]" template. Assert the popup shows the looked-up term, and that the reused window follows the next lookup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since e21138a ("Use new js library"), DictButton._load_popup builds lookup_url (with [LUTE] replaced by the term) but passes the raw dict url to LutePopups.open_popup, so popup dictionaries search for the literal "[LUTE]" (e.g. Forvo 404s, japandict searches "[lute]").
Pass lookup_url instead.
The existing popup acceptance tests only counted windows, so they didn't catch this.
test_dictionary_popup_reuses_windownow also checks that the popup shows the looked-up term, and that the reused window follows the next lookup. It fails without the fix and passes with it.🤖 Generated with Claude Code