Repository navigation
chore(deps): take react and react-dom to 19 in one change - #404
Open
IanoNjuguna wants to merge 1 commit into
Open
IanoNjuguna wants to merge 1 commit into
IanoNjuguna wants to merge 1 commit into
Conversation
Dependabot opened this major as two PRs, IntersectMBO#401 for react and IntersectMBO#402 for react-dom plus @types/react-dom. Each half breaks the other's peer requirement, so neither can pass npm ci on its own: IntersectMBO#402: Found: react@18.3.1, could not resolve peer react@^19.3.1 from react-dom@19.3.1 IntersectMBO#401: Found: react@19.3.1, could not resolve peer react-dom@^18.3.1 from react-dom@18.3.1 This takes the peer set together, which is the only shape that resolves, and regenerates website/package-lock.json from scratch instead of editing it. @types/react-dom is ^19.3.0, not ^19.3.1, which does not exist. @docusaurus/core 3.10.2 declares react ^18.0.0 || ^19.0.0, so 19 is inside the supported range. The @slorber/react-helmet-async alias it depends on still advertises a peer range capped at react 18: that is a warning, the install exits 0, and the build is clean. Verified on Node 24.18.1 against main at 973801b: npm install 1409 packages, no ERESOLVE npm ci exit 0 on the regenerated lock npm run build SUCCESS, static files generated Refs IntersectMBO#403
This was referenced Nov 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Takes
reactandreact-domto 19 in one change, with a regenerated lockfile.Dependabot opened the major as two PRs and neither can pass alone, because each half breaks the other's peer requirement:
Merging them back to back does not work either:
deploy.ymlruns on every push tomain, so between the two merges the tracked lockfile does not resolve, the build job fails and the Pages deploy is skipped. Any PR updated in that window inherits the broken lockfile.This PR supersedes #401 and #402 and closes #403.
Type of Change
Testing
Checklist
Verification
Run in a worktree of
mainat 973801b, aftergit checkoutof this branch:On the warnings:
@docusaurus/core3.10.2 declaresreact^18.0.0 || ^19.0.0, so 19 is inside its supported range.@slorber/react-helmet-asyncalias that@docusaurus/coredepends on still advertises a peer range capped at react 18. It reportsnpm warnand the install exits 0; the build is clean.Notes
@types/react-domgoes to^19.3.0;19.3.1does not exist.website/package.jsonstill haspackageManager: yarn@1.22.22and aresolutionsblock pinningreactandreact-domto^18.3.1. npm ignores both, but ayarn installwould restore react 18. Noted on react 19: the Dependabot halves cannot resolve alone, so the bump needs one combined PR #403.groupsentry in.github/dependabot.ymlcovering the react peer set, so the next major arrives as one PR.