Skip to content

react 19: the Dependabot halves cannot resolve alone, so the bump needs one combined PR #403

Open

Description

@IanoNjuguna

Dependabot opened the react 19 major as two PRs, and neither can pass on its own:

Each half breaks the other's peer requirement, so both fail npm ci with ERESOLVE:

#402: Found: react@18.3.1
      Could not resolve dependency: peer react@^19.3.1 from react-dom@19.3.1

#401: Found: react@19.3.1
      Could not resolve dependency: peer react-dom@^18.3.1 from react-dom@18.3.1

Merging them one after the other does not fix it either. deploy.yml runs on every push to main, so between the two merges the tracked lockfile does not resolve, the build job fails, and the Pages deploy is skipped. Any PR opened in that window inherits the same broken lockfile.

Proposed fix

One PR that takes the peer set together, with a regenerated lockfile:

  • react and react-dom to ^19.3.1
  • @types/react-dom to ^19.3.0 (19.3.1 does not exist)

Verified locally against main at 973801b:

  • npm install with the bumped versions: 1409 packages, no ERESOLVE
  • npm ci against the regenerated website/package-lock.json: exit 0
  • npm run build: SUCCESS, static files generated

@docusaurus/core 3.10.2 declares react ^18.0.0 || ^19.0.0, so 19 is inside the supported range. The @slorber/react-helmet-async alias it depends on prints a peer warning capped at react 18, and the install still exits 0.

Related, separate

website/package.json still carries packageManager: yarn@1.22.22 and a resolutions block pinning react and react-dom to ^18.3.1, both stale since the repo standardised on npm. A yarn install would put react 18 back. npm ignores both, so this does not block the bump, but it should be cleaned up in its own change.

Also worth considering: a groups entry in .github/dependabot.yml covering the peer set, so the next react major arrives as one PR instead of two unresolvable halves.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions