Skip to content

curate(stage5): resolve Cycle 5 Stage 4 definition_source review findings (#2002) - #2026

Merged
realmarcin merged 1 commit into
mainfrom
c5s5-resolve-review-findings
Oct 25, 2026
Merged

realmarcin merged 1 commit into
mainfrom
c5s5-resolve-review-findings

Conversation

@realmarcin

Copy link
Copy Markdown
Contributor

Summary

  • Goal (mech-goal-sequence-20261019, Cycle 5, Stage 5 resolve_review_findings): Consume Cycle 5 Stage 4's accepted review outputs (reviews/workflow/mech-goal-sequence-20261019/cycle-000005/stage-04/revision-0001/evidence.yaml and reviews/structured/20261025T200500Z-cycle5-stage4-corpus-record-and-cohort-review/review.yaml), group carried-forward findings by cause and repair ownership, link every group and finding to a deduplicated GitHub issue (#2002, #1982, #1983, #1984, #1985, #364), implement the accepted fixes for all 7 open record-level definition_source findings (F-C5S4-DEF-SRC-001..007) via guarded writer scripts/curate_stage5_review_findings.py, regenerate pages/, and obtain a fresh structured review (reviews/structured/20261025T214500Z-cycle5-stage5-remediated-records-review/).
  • 7 Open Findings Resolved (G-C5S4-RECORD-LEVEL-DEFINITION-SOURCE-SNIPPETS, Cycle 3 Stage 4/5 grouped remediation: add verbatim definition_source snippets to record-level evidence on 17 traits #2002):
    1. F-C5S4-DEF-SRC-001: data/traits/genomics/gao_her_duf_system.yaml (traitmech:000361) — aligned evidence[0].reference from PMID:32855333 to DOI:10.1126/science.aba0372 while preserving verified verbatim snippet.
    2. F-C5S4-DEF-SRC-002: data/traits/genomics/gao_her_sir_system.yaml (traitmech:000362) — aligned evidence[0].reference from PMID:32855333 to DOI:10.1126/science.aba0372 while preserving verified verbatim snippet.
    3. F-C5S4-DEF-SRC-003: data/traits/genomics/genome_streamlining.yaml (traitmech:000099) — promoted verified verbatim snippet 'minimizes resources required for replication' for DOI:10.1038/ismej.2014.60 (from oligotrophic.yaml).
    4. F-C5S4-DEF-SRC-004: data/traits/metabolism/biopolymer_degradation.yaml (traitmech:000110) — promoted verified verbatim snippet 'The enzymatic degradation of cellulose and hemicellulose is accomplished in Nature via the collective action of multiple carbohydrate-active enzymes' for DOI:10.1016/j.cbpa.2015.10.018 (from saprotrophy.yaml).
    5. F-C5S4-DEF-SRC-005: data/traits/metabolism/denitrification.yaml (traitmech:000104) — promoted verified verbatim snippet 'N oxides as terminal electron acceptors' for DOI:10.1128/mmbr.61.4.533-616.1997 (from nitrogen_respiration.yaml).
    6. F-C5S4-DEF-SRC-006: data/traits/metabolism/sulfur_oxidation.yaml (traitmech:000106) — promoted verified verbatim snippet 'lithotrophic sulfur oxidation' for DOI:10.1111/j.1574-6976.2009.00187.x (from lithotrophic.yaml).
    7. F-C5S4-DEF-SRC-007: data/traits/physiology/catalase_activity.yaml (traitmech:000075) — promoted verified verbatim snippet 'hydrogen peroxide to water and molecular oxygen, serving to protect cells' for DOI:10.1007/s00018-003-3206-5 (from oxidative_stress_response.yaml).
  • Workflow Closure Index: Updated reviews/workflow/latest.yaml from verified-evidence-index.json (adding verified Cycle 5 Stage 4 closure entry for PR #2020).

Refs #2002

@realmarcin
realmarcin added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit bc1dfa7 Oct 25, 2026
8 checks passed
@realmarcin
realmarcin deleted the c5s5-resolve-review-findings branch October 25, 2026 23:07
realmarcin added a commit that referenced this pull request Oct 26, 2026
Main gained a curation PR (#2026) that edits seven trait records and their
pages. Git merged the generated pages textually, which mixes main's data with
this branch's templates. Per the curation playbook, pages/ was regenerated
with just gen-pages rather than trusted: seven record pages and schema.html
differed from the auto-merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant