Repository navigation
fix: k8s e2e creates the client policy after its trust secret - #635
Merged
Merged
Conversation
This was referenced Oct 27, 2026
k82cn
added a commit
that referenced
this pull request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes E2E job fails intermittently in "Configure external access" with
ClientTrafficPolicy/flame-cache-client-mtls was not accepted(seen on #634, run 40440554603;e2e-k8sfailed 2 of its last 30 runs, 10 were cancelled).Cause
ci/k8s/e2e.shapplied the wholeexternal-access.yaml, including theClientTrafficPolicythat references the secretflame-cache-client-trust, and only afterwards waited for the client CA certificate and created that secret from it. In the failing run the policy and the secret were created in the same second, and the status Envoy Gateway wrote for the policy was:That status was still there five minutes later, when
wait_client_policy_acceptedgave up: the policy was not accepted again after the secret appeared. Whether it is accepted depends on which of the two Envoy Gateway sees first, hence the intermittent failure.Change
The
ClientTrafficPolicymoves to its own template,ci/k8s/external-access-client-policy.yaml, ande2e.shrenders and applies it right after it creates the trust secret, so the secret always exists when the policy does. The other resources, the order of the waits, and the policy itself are unchanged; the 17 documents of the old template are now 16 plus this one.Checked
bash -n ci/k8s/e2e.sh; both templates parse as YAML, and the old template's documents are exactly the union of the two (same kinds and names).Kubernetes E2E Test. Because the failure is intermittent, one green run does not prove the change; the argument is that the missing secret in the status above can no longer happen.