Repository navigation
[release-0.7] fix: read the flamepy version without color in the release metadata check - #629
Merged
Merged
Conversation
…heck (xflops#623) (cherry picked from commit 548f063)
k82cn
force-pushed
the
backport/pr-623-release-0.7
branch
from
October 26, 2026 12:10
84bedee to
9699735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks #623 onto
release-0.7.This backport contains only commit
84bedee4(the release-branch cherry-pick of548f0636), made withgit cherry-pick -x. It applied without conflicts, and its patch-id matches the source commit.Why it is needed: the
Release Metadatajob of thev0.7.0-rc1publish run failed, so nothing was published for rc1.hack/release.shread the package version withuv version --short, andrelease-publish.yamlforces terminal colors, souvwrapped the version in color codes and the comparison with__version__failed (0.7.0rc1 != ^[[36m0.7.0rc1^[[39m). The publish workflow runshack/release.shfrom the tagged commit, so this has to be onrelease-0.7beforev0.7.0-rc2is tagged.The rc2 preparation PR (#624) carries the same one-line change in its own commit, so merging this one and that one in either order leaves
hack/release.shidentical.Validation, on the
release-0.7base:CLICOLOR_FORCE=1 hack/release.sh validate-metadata v0.7.0-rc1passes and reportscargo-version=0.7.0-rc1,python-version=0.7.0rc1anddocker-tag=v0.7.0-rc1; with the olduv version --shortline it fails with the rc1 error.