Skip to content

Allow rendering at 25 % of the resolution - #151

Closed
ksooo wants to merge 1 commit into
xbmc:Piersfrom
ksooo:render-scale-25
Closed

ksooo wants to merge 1 commit into
xbmc:Piersfrom
ksooo:render-scale-25

Conversation

@ksooo

@ksooo ksooo commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Adds a 25 % step to the "Render Quality" setting, which so far went down to 50 %.

On an NVIDIA Shield Pro 2019 at 3840x2160, heavy presets, e.g. from Mischa's Collection, still drop frames at 50 %. Render() already handles any percentage, so only the setting's minimum changes.

No version bump yet, as #150 already raises it to 22.3.1.

Summary by CodeRabbit

  • New Features
    • The minimum render scale can now be set to 25, down from 50.

On an NVIDIA Shield at 4K, heavy presets still drop frames at 50 %.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a6dceca4-b4d7-4c87-a329-2a489a82edc3
📥 Commits

Reviewing files that changed from the base of the PR and between 4f1d21a and 2773f9b.

📒 Files selected for processing (1)
  • visualization.projectm/resources/settings.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The render_scale setting now accepts values as low as 25 instead of 50.

Changes

Render scale setting

Layer / File(s) Summary
Update render_scale minimum
visualization.projectm/resources/settings.xml
The minimum value for render_scale changes from 50 to 25.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 2773f

The new option allows smaller render dimensions to reduce rendering load. No actionable merge-blocking risk is evident in the changed setting or its described rendering path.

Architecture Summary

Architecture risk: 🔵 Low · up to 2773f

The change affects 1 system.

Changed systems: visualization.projectm

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — visualization.projectm (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in visualization.projectm/resources/settings.xml: render_scale now allows a minimum of 25 instead of 50.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: allowing rendering at 25% resolution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Adjusts the minimum rendering resolution setting.

This PR appears safe to merge.

What we checked:

  • Quarter-size rendering remains supported: Render() uses the selected percentage directly. It does not require a 50% minimum, and it rebuilds the render target when dimensions change.
Summary

Adds a 25% option to Render Quality by lowering the minimum for render_scale.

  • Keeps the default at 100% and the step at 25%.
  • Uses the existing rendering code without changes.
  • No actionable issues found.

Reviews (1) · Last reviewed commit: "addon: Allow rendering at 25 % of the re..." · Reviewed by Greptile

@ksooo

ksooo commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Closing: on the NVIDIA Shield, 25 % doesn't noticeably reduce the frame drops compared to 50 %.

@ksooo ksooo closed this Oct 7, 2026
@ksooo
ksooo deleted the render-scale-25 branch October 7, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant