Repository navigation
Conversation
On an NVIDIA Shield at 4K, heavy presets still drop frames at 50 %.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesRender scale setting
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The new option allows smaller render dimensions to reduce rendering load. No actionable merge-blocking risk is evident in the changed setting or its described rendering path. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Closing: on the NVIDIA Shield, 25 % doesn't noticeably reduce the frame drops compared to 50 %. |
Adds a 25 % step to the "Render Quality" setting, which so far went down to 50 %.
On an NVIDIA Shield Pro 2019 at 3840x2160, heavy presets, e.g. from Mischa's Collection, still drop frames at 50 %.
Render()already handles any percentage, so only the setting's minimum changes.No version bump yet, as #150 already raises it to 22.3.1.
Summary by CodeRabbit