Repository navigation
Incrementally emit Lua scalar locals spilling and loop demotion - #1581
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalar hot reload edits now keep the incremental path when the function reaches Lua's local/register limit. Previously these functions fell back to whole-program copying and backend work. The private function runs the existing numeric-loop demotion and locals-table spilling producers, preserving the batch compiler's runtime representation and numeric spill slots.
The cold spilling producer records its generated table binding in the immutable function frame. Private emission consumes that binding directly, preserving collisions with local and global names without rebuilding a program-wide naming environment. The existing closed-body, unchanged-structure/source-position and compiler-option restrictions still apply. Calls, stack traces, compile-time execution, local optimisations and garbage-producing bodies remain outside this slice. Source scans, full-script assembly, hashing and payload comparison still process the program; this change makes no real-map latency claim.
Validation:
20261026130through20261026134: 500 generated scalar programs around the local/register limit with 1,500 warm edits compared against independent fresh Lua/manifests/payloads, plus 500 existing hot-reload fuzz programs with anonymous insertion enabled. XML receipts verify no failures/errors/skips in every batch. An earlier single-task attempt hit Gradle's fixed 20-minute task limit and is not counted as a successful campaign.61ab6fff8c512344f9305af6f37b2a39ad8ad39fwith no findings; complete review snapshots were stable. macOS and Warcraft client execution remain unverified locally.