Repository navigation
Parse PmLog metadata for multi-digit PID and TID fields - #449
Merged
Merged
Conversation
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #354 as a related log-metadata prerequisite.
PmLog records with realistic IDs such as
[1234:5678]fell back to an unknown process/context and kept the entire raw line as the message. The parser allowed only one character in each PID/TID field. Allow multi-character fields while preserving the existing single-character and empty[]forms.Validation:
logread()stream: multi-digit/mixed-length IDs, single digits, empty IDs, timestamp/monotonic/severity/process/context/msgid metadata, nested JSON extras and message text, fallback records, and blank lines.npm test: 131 tests passed across 15 files.npm run ng -- build --configuration=development: passed (existing browser-support/Sass warnings).git diff --check: passed.No TV was used; fixtures reproduce the log-record parsing failure through a mocked command stream. Filtering and export remain separate work in #354.
Integration validation: #449, #450, and #451 apply together without conflicts; all 213 combined headless tests pass. A current public repository snapshot with 56 packages passes the combined page validation and same-version comparison checks.