You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: Allow a decimal keyboard in the shared text field (#16) - #17
The shared controlled text field can now request a decimal keyboard on touch devices while keeping its value and native form submission as the original string. This supports localized decimal entry while leaving parsing and validation to consuming applications.
What changed
Added optional inputMode: 'decimal' state and applied the native inputmode hint while retaining the text input.
Preserved controlled values, focus, and form submissions when the hint changes, including comma decimals such as 2,25.
Updated the core and adapter package cohort to 0.1.0-next.2 and added field contract documentation.
Added coverage for state validation, browser behavior, and packed framework consumers.
Validation
Author-provided evidence reports 1,474 tests passed and 100% across all four coverage metrics and every authored file.
Author-provided evidence reports reproducible package archives and packed browser, React, Vue, Angular, and Svelte fixtures verifying the native hint and unchanged 2,25 submission.
Review notes
Publication and adoption in Domus remain outstanding delivery steps.
Status: Effective branch rules must be readable and dismiss stale approvals. Completed: 1/1 observed checks succeeded; Bugbot complete. Action required: Fix the named prerequisite and rerun the observer. Impact: No new approval is confirmed for this revision. See checks
Verified head 179e5c1bcd4a78e3e7186e4c57b6b98e1bc6aa76 against develop 02b8e80f3dbd9a931fbe547c7fdae9c614d73da3.
CI Check completed successfully. It checked 100% source coverage, all five packed consumers, all three SSR fixtures, Chromium, Firefox, WebKit and the built Storybook catalog.
Verification passed and Review reported no findings. The PR has no open review threads.
The exact head has successful Branch Sync. Develop's own exact CI and Branch Sync are also successful.
The approval observer reports unsafe-rules because the development branch lacks stale-approval dismissal rules. The repository policy configures this observer in recommend mode, and the effective develop rules contain no required check. This result concerns automated approval. The exact CI, verification and review above establish the checks for the normal reviewed merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80%Progress: 80%size: XXLLabel to indicate a task of size XXLstate:verifiedThe change has passed Copilot verification.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared controlled text field can now request a decimal keyboard on touch devices while keeping its value and native form submission as the original string. This supports localized decimal entry while leaving parsing and validation to consuming applications.
What changed
inputMode: 'decimal'state and applied the nativeinputmodehint while retaining the text input.2,25.0.1.0-next.2and added field contract documentation.Validation
2,25submission.Review notes
Closes #16