Skip to content

feat: Allow a decimal keyboard in the shared text field (#16) - #17

Merged
efraespada merged 4 commits into
developfrom
feature/16-allow-a-decimal-keyboard-in-the-shared-text-field
Nov 11, 2026
Merged

efraespada merged 4 commits into
developfrom
feature/16-allow-a-decimal-keyboard-in-the-shared-text-field

Conversation

@efraespada

@efraespada efraespada commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

The shared controlled text field can now request a decimal keyboard on touch devices while keeping its value and native form submission as the original string. This supports localized decimal entry while leaving parsing and validation to consuming applications.

What changed

  • Added optional inputMode: 'decimal' state and applied the native inputmode hint while retaining the text input.
  • Preserved controlled values, focus, and form submissions when the hint changes, including comma decimals such as 2,25.
  • Updated the core and adapter package cohort to 0.1.0-next.2 and added field contract documentation.
  • Added coverage for state validation, browser behavior, and packed framework consumers.

Validation

  • Author-provided evidence reports 1,474 tests passed and 100% across all four coverage metrics and every authored file.
  • Author-provided evidence reports reproducible package archives and packed browser, React, Vue, Angular, and Svelte fixtures verifying the native hint and unchanged 2,25 submission.

Review notes

  • Publication and adoption in Domus remain outstanding delivery steps.

Closes #16

@docs-page

docs-page Bot commented Nov 11, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/ha-ui~17

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XXL Label to indicate a task of size XXL state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 11, 2026
@vypbot vypbot changed the title Allow a decimal keyboard in shared text fields feat: Allow a decimal keyboard in the shared text field (#16) Nov 11, 2026
@vypbot
vypbot self-requested a review November 11, 2026 16:44
@vypbot vypbot added this to vypdev Nov 11, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 11, 2026
@vypbot
vypbot changed the base branch from develop to master November 11, 2026 16:44
@efraespada efraespada linked an issue Nov 11, 2026 that may be closed by this pull request
1 task done
@vypbot
vypbot changed the base branch from master to develop November 11, 2026 16:45
@vypbot

vypbot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Approval blocked

Status: Effective branch rules must be readable and dismiss stale approvals.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Fix the named prerequisite and rerun the observer.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 179e5c1bcd4a; base: 02b8e80f3dbd; reason: unsafe-rules.

@vypbot

vypbot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 179e5c1.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. 80% Progress: 80% and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 11, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Nov 11, 2026
@efraespada

Copy link
Copy Markdown
Member Author

Verified head 179e5c1bcd4a78e3e7186e4c57b6b98e1bc6aa76 against develop 02b8e80f3dbd9a931fbe547c7fdae9c614d73da3.

  • CI Check completed successfully. It checked 100% source coverage, all five packed consumers, all three SSR fixtures, Chromium, Firefox, WebKit and the built Storybook catalog.
  • Verification passed and Review reported no findings. The PR has no open review threads.
  • The exact head has successful Branch Sync. Develop's own exact CI and Branch Sync are also successful.

The approval observer reports unsafe-rules because the development branch lacks stale-approval dismissal rules. The repository policy configures this observer in recommend mode, and the effective develop rules contain no required check. This result concerns automated approval. The exact CI, verification and review above establish the checks for the normal reviewed merge.

@efraespada
efraespada merged commit cc805db into develop Nov 11, 2026
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 11, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

80% Progress: 80% size: XXL Label to indicate a task of size XXL state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

✨🧑‍💻 - Allow a decimal keyboard in the shared text field

2 participants