Repository navigation
fix: reap the Vale child when writing its stdin fails - #34
Open
chad-loder wants to merge 1 commit into
Open
chad-loder wants to merge 1 commit into
chad-loder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Vale exits before reading all of stdin (a config error, say),
write_allfails with a broken pipe and the early return drops theChildwithout waiting on it, leaving a zombie per failed lint for the life of the server. The child is now always waited on, and its own output, which explains the failure, is what gets parsed.The test uses a stand-in
valethat exits without reading a 1 MiB buffer.