Repository navigation
Conversation
Apply sampled offsets to both keys and caller-provided vectors. Keep one-dimensional vector input valid before selecting rows. Closes unum-cloud#847.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #847.
When
self_recall()samples keys but receives an explicit vector matrix, the vectors retain their original rows. Search results are then compared with different sampled identities, so a correct index can report recall 0.0 instead of 1.0.Select the same vector rows as the keys. Normalize supplied vectors to two dimensions before indexing to preserve single-vector inputs.
Validation on 3.0 main
840374af:git diff --checkpass. Its hook self-test reports 534 passed / 0 failed.Python 3.13.13 / NumPy 2.5.4 on macOS arm64, with the 3.0 CPU SDK and its pinned NumKong 8.0.0-rc.1 dependency built from source. The full Python, other-language and GPU test matrices were not run.