Repository navigation
fix: protect credentials in error diagnostics - #375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL connection failures include the credential-bearing DSN in CLI errors, and upload transport failures can include pre-signed URL credentials. When telemetry is enabled, the first line of an error is also transmitted off-host.
Remove the DSN from connection errors and mask credential-bearing URLs in terminal error output. Reuse JSON redaction for SDK API error bodies, omit non-JSON bodies, and retain HTTP status and trace information. Stop including free-form error messages in telemetry while preserving the failure result.
API response bodies are not inherently secret; disclosure depends on their contents. This change masks known sensitive JSON fields and URL parameters, rather than attempting to identify arbitrary secrets in free text.
Validation:
GOWORK=off go test ./internal/redact ./internal/util ./internal/telemetry ./internal/service/cloud ./internal/cligoimportsandgit diff --checkRegression coverage includes SQL DSNs, wrapped upload URL errors, API body redaction, and omission of telemetry error text.