[vovosta]

I made a few changes to address issue #83.

I haven't been able to run the tests locally yet, so these changes have not been verified locally. Feedback and testing are welcome!

What's Changed

• Fixed the ASSERT_THROW macro by adding a check to ensure that the expected exception is actually thrown.
• Modified the EXPECT_* macros so that the test continues running even when an expectation fails. Added a counter to track failed expectations and ensured that these failures are reflected in the final test results.

Related Issue

• Closes [BUG]: Test assertion macros can report failing checks as passed #83

Checklist

• Code builds successfully without compiler warnings or errors
• Added or updated unit/regression tests for the changes
• All tests pass successfully locally
• Documentation updated (if applicable)

[vovosta]

If there's any issues do not hesitate to tell me !

[tecnolgd]

Hey @vovosta, thanks for the fix!

Before we get this merged, could you please update your pull request title to something more descriptive (for example: Fix test assertion macros reporting false passes)? It helps keep our commit history clean. Check the relevant boxes in the checklist as per the changes.
Also, since you mentioned you couldn't run tests locally, make sure you have executed make test to confirm your changes to test_framework.hpp passed successfully! Once those are green, your PR is good to go.

[vovosta]

Hey, i'll change the name right now.
I just have an issue : i don't have my main pc available right now, and i don't have enough storage on the pc i have right now. I don't know if it would be possible if someone else tries the code ?
I'm really sorry to ask that but i really don't have any choices for now.

Sorry to bother you,

[tecnolgd]

Hey, i'll change the name right now. I just have an issue : i don't have my main pc available right now, and i don't have enough storage on the pc i have right now. I don't know if it would be possible if someone else tries the code ? I'm really sorry to ask that but i really don't have any choices for now.

Sorry to bother you,

No worries at all! I totally understand.

The CI is completely green, but I just need some time to perform local tests to double-check everything before merging.
Thanks for updating the title(did some minor edits myself which I forgot to mention earlier) and for the solid work on the macro fix.

[vovosta]

Hey, i think i found a way to compile it locally.
I resolved an issue for an other repo and they told me how to test it on github using the action tab.
I try it and i'll comeback to you soon.

[vovosta]

After all, i'll let you do it because i'm having some issues rn, sorry.
Also, thanks for doing it !!!!

[tecnolgd]

I verified the changes locally. Everything LGTM. Thanks again!

[vovosta]

Thanks so much ! I'm so happy to contribute to the project !