Skip to content

chore(trino): Add 483, remove 479 - #1690

Merged
NickLarsenNZ merged 16 commits into
mainfrom
trino-483
Oct 13, 2026
Merged

chore(trino): Add 483, remove 479#1690
NickLarsenNZ merged 16 commits into
mainfrom
trino-483

Conversation

@NickLarsenNZ

@NickLarsenNZ NickLarsenNZ commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #1657

  • Add 483 (incl trino-cli).
  • Update vendored deps, add docs and a Claude skill to make this easier.
  • Remove 479.

Note

  • Since Trino 483, we no longer ship trino-storage-connector (now archived).
    Parent issue contains the release note.
  • Note: Separate Dockerfiles since Trino moved to bun (cdxgen needs bun.lock instead of package-lock.json).

@NickLarsenNZ NickLarsenNZ self-assigned this Oct 9, 2026
@NickLarsenNZ NickLarsenNZ changed the title Trino 483 chore(trino): Add 483, remove 479 Oct 9, 2026
@NickLarsenNZ NickLarsenNZ mentioned this pull request Oct 12, 2026
Closed
17 tasks done
@NickLarsenNZ

NickLarsenNZ commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

Testing

--- PASS: kuttl/harness/cluster-operation_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (125.80s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-true_use-tls-true_use-internal-tls-false_openshift-false (79.18s)
--- PASS: kuttl/harness/listener_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (81.80s)
--- FAIL: kuttl/harness/smoke_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_hive-4.2.0_opa-latest-1.16.2_hdfs-3.5.0_zookeeper-3.9.6_openshift-false (413.67s)
--- FAIL: kuttl/harness/smoke_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_hive-3.1.3_opa-latest-1.16.2_hdfs-3.5.0_zookeeper-3.9.6_openshift-false (350.57s)
--- PASS: kuttl/harness/client-spooling_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (140.58s)
--- PASS: kuttl/harness/resources_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (60.54s)
--- PASS: kuttl/harness/orphaned-resources_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (52.71s)
--- PASS: kuttl/harness/opa-authorization_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_hive-latest-4.2.0_opa-latest-1.16.2_keycloak-25.0.0_openshift-false (424.56s)
--- PASS: kuttl/harness/logging_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (106.07s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-true_use-tls-true_use-internal-tls-true_openshift-false (82.13s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-false_use-tls-false_use-internal-tls-true_openshift-false (74.89s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-true_use-tls-false_use-internal-tls-true_openshift-false (74.63s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-true_use-tls-false_use-internal-tls-false_openshift-false (68.21s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-false_use-tls-true_use-internal-tls-true_openshift-false (77.09s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-false_use-tls-true_use-internal-tls-false_openshift-false (73.57s)
--- PASS: kuttl/harness/fault-tolerant-execution_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_openshift-false (179.07s)
--- PASS: kuttl/harness/tls_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_use-authentication-false_use-tls-false_use-internal-tls-false_openshift-false (74.63s)
--- PASS: kuttl/harness/authentication_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_ldap-use-tls-true_openshift-false (269.11s)
--- PASS: kuttl/harness/authentication_trino-latest-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_ldap-use-tls-false_openshift-false (276.87s)

Replacing minio with garage, then rerunning tests.

@NickLarsenNZ

NickLarsenNZ commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

Failing tests passed:

--- PASS: kuttl/harness/smoke_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_hive-3.1.3_opa-latest-1.16.2_hdfs-3.5.0_zookeeper-3.9.6_openshift-false (271.57s)
--- PASS: kuttl/harness/smoke_trino-483,oci.stackable.tech_sdp_trino_483-stackable0.0.0-dev-amd64_hive-4.2.0_opa-latest-1.16.2_hdfs-3.5.0_zookeeper-3.9.6_openshift-false (279.07s

@NickLarsenNZ
NickLarsenNZ marked this pull request as ready for review October 13, 2026 08:42
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Oct 13, 2026
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Progress in Stackable Engineering Oct 13, 2026
@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 13, 2026
sbernauer
sbernauer reviewed Oct 13, 2026
View reviewed changes
Comment thread trino/storage-connector/Dockerfile Outdated
sbernauer
sbernauer reviewed Oct 13, 2026
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't really review the two big MD files on the js sbom situation, other than the comment LGTM

@NickLarsenNZ
revert(storage): Remove condition that was accidentally brought in
34b134f 
This was one of the attempts to built trino without the storage connector, but we ended up going with separate dockerfiles in 982b7ac
@NickLarsenNZ

NickLarsenNZ commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

Didn't really review the two big MD files on the js sbom situation, other than the comment LGTM

I'd say no need to review. Some docs are better than nothing. They can be improved over time.

sbernauer
sbernauer previously approved these changes Oct 13, 2026
View reviewed changes
sbernauer
sbernauer approved these changes Oct 13, 2026
View reviewed changes

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 13, 2026
@NickLarsenNZ
NickLarsenNZ disabled auto-merge October 13, 2026 13:50
@NickLarsenNZ
NickLarsenNZ added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 724ef70 Oct 13, 2026
3 checks passed
@NickLarsenNZ
NickLarsenNZ deleted the trino-483 branch October 13, 2026 13:51
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels

None yet

Projects

Stackable Engineering
Status: Development: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickLarsenNZ @sbernauer