Repository navigation
Decode encoded AMQP URI values when no port is specified in spring-boot-amqp-rabbitmq - #52819
Open
manthansharma6767 wants to merge 1 commit into
Open
manthansharma6767 wants to merge 1 commit into
manthansharma6767 wants to merge 1 commit into
Conversation
…ot-amqp-rabbitmq Update `RabbitUri` in `spring-boot-amqp-rabbitmq` to also decode relevant parts of the URI when no port is specified. Also fix a copy-paste error in `RabbitUriTests` where `determinePassword` was asserted instead of `determineVirtualHost`. Closes spring-projectsgh-52818 Signed-off-by: Manthan Sharma <manthansharma795@gmail.com>
Member
|
Duplicates #52644 |
Member
|
My mistake, I see this is in a different module. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-52818
Prior to this commit,
RabbitUri.of(String)inmodule/spring-boot-amqp-rabbitmqdid not decode URL-encoded components (username, password, and virtual host) if no explicit port was specified in the address URI.This commit:
RabbitUri.of(String)inspring-boot-amqp-rabbitmqto decode credentials and virtual host when no port is specified, matching the behavior inspring-boot-rabbitmq(Encoded AMQP URI values are not decoded when no port is specified #52644).RabbitUriTests.determineVirtualHostWhenHasNoUserDefinedVirtualHost()wheredeterminePasswordwas checked instead ofdetermineVirtualHost.