Skip to content

Decode encoded AMQP URI values when no port is specified in spring-boot-amqp-rabbitmq - #52819

Open
manthansharma6767 wants to merge 1 commit into
spring-projects:mainfrom
manthansharma6767:fix/gh-52818-decode-amqp-rabbit-uri
Open

manthansharma6767 wants to merge 1 commit into
spring-projects:mainfrom
manthansharma6767:fix/gh-52818-decode-amqp-rabbit-uri

Conversation

@manthansharma6767

Copy link
Copy Markdown
Contributor

Closes gh-52818

Prior to this commit, RabbitUri.of(String) in module/spring-boot-amqp-rabbitmq did not decode URL-encoded components (username, password, and virtual host) if no explicit port was specified in the address URI.

This commit:

  • Updates RabbitUri.of(String) in spring-boot-amqp-rabbitmq to decode credentials and virtual host when no port is specified, matching the behavior in spring-boot-rabbitmq (Encoded AMQP URI values are not decoded when no port is specified #52644).
  • Fixes a copy-paste assertion in RabbitUriTests.determineVirtualHostWhenHasNoUserDefinedVirtualHost() where determinePassword was checked instead of determineVirtualHost.
  • Adds unit tests covering port-less URIs with URL-encoded values.

…ot-amqp-rabbitmq

Update `RabbitUri` in `spring-boot-amqp-rabbitmq` to also decode relevant
parts of the URI when no port is specified. Also fix a copy-paste error
in `RabbitUriTests` where `determinePassword` was asserted instead of
`determineVirtualHost`.

Closes spring-projectsgh-52818

Signed-off-by: Manthan Sharma <manthansharma795@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue that has not yet been triaged. Contributions will not be accepted. label Nov 16, 2026
@philwebb

Copy link
Copy Markdown
Member

Duplicates #52644

@philwebb philwebb closed this Nov 16, 2026
@philwebb philwebb added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue that has not yet been triaged. Contributions will not be accepted. labels Nov 16, 2026
@philwebb philwebb reopened this Nov 16, 2026
@philwebb

Copy link
Copy Markdown
Member

My mistake, I see this is in a different module.

@philwebb philwebb added type: bug A general bug and removed status: duplicate A duplicate of another issue labels Nov 16, 2026
@philwebb philwebb added this to the 4.2.x milestone Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decode encoded AMQP URI values when no port is specified in spring-boot-amqp-rabbitmq

3 participants