Repository navigation
Add support for trait objects in make_collectable - #52
jacob-hughes wants to merge 2 commits into
Conversation
|
The block comment in |
This sounds like it's a non-starter to me? But, perhaps, we can solve this by benchmarking yksom with and without this change? If it doesn't make much difference we can forget about it. If it does make a difference then we might have some thinking to do! |
This change is motivated by yksom. Almost all VM objects in yksom are allocated with the type However, not all hope is lost. There's a couple of observations I've noticed in yksom that mean this isn't the end of the world:
|
|
@jacob-hughes what's the plan with this PR now? |
|
Closing this because in favour of a new PR because in its current form I think it's too dangerous |
This is a surprisingly small PR but with very big implications (hence the large block comment).
This is a draft PR because I'm not sure if the benefit of allowing the
NoFinalizeoptimisation on types containing trait objects is worth the risk that it introduces. I'd like to know your thoughts before merging.