Skip to content

fix(circleci): use open_source-managed context for security-scans - #153

Merged
gergo-papp merged 1 commit into
mainfrom
prodsec/fix-security-scans-context
Aug 28, 2026
Merged

gergo-papp merged 1 commit into
mainfrom
prodsec/fix-security-scans-context

Conversation

@wayne-grant

Copy link
Copy Markdown
Contributor

Summary

  • The security-scans job (wrapping prodsec/security_scans) in .circleci/config.yml was using the analysis_unify CircleCI context.
  • Standardizing on open_source-managed, the context used by the large majority of snyk/engines_sca-scanners-owned repos for this job.

Context

Identified as part of an audit of prodsec/security_scans, prodsec/container_scan, and publish/publish CircleCI contexts across all sca-scanners repos.

Test plan

  • Confirm the security-scans job runs successfully on this branch/PR with the new context
  • Confirm SNYK_TOKEN and other required env vars are present in open_source-managed

Standardizes the CircleCI context on the security-scans job (prodsec/security_scans)
to open_source-managed, matching the convention used across the majority of
snyk/engines_sca-scanners repos.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@snyk-io

snyk-io Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@wayne-grant
wayne-grant marked this pull request as ready for review August 28, 2026 09:49
@wayne-grant
wayne-grant requested a review from a team as a code owner August 28, 2026 09:49
@snyk-pr-review-bot

This comment has been minimized.

@wayne-grant
wayne-grant marked this pull request as draft August 28, 2026 09:51
@wayne-grant
wayne-grant marked this pull request as ready for review August 28, 2026 09:53
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Indentation Error 🟠 [major]

The added context '- open_source-managed' is indented with 12 spaces, whereas the subsequent item '- prodsec-orb-runtime' is indented with 14 spaces. In YAML, list items must be aligned at the same indentation level. This mismatch will likely cause a YAML parsing error in CircleCI. Align the new item with the existing one (14 spaces) to match the style used in the 'prodsec/secrets-scan' job above.

- open_source-managed
Operational Risk 🟡 [minor]

The 'security-scans' job lacks branch filters, meaning it runs on the default branch ('main') as well as all feature branches. If the 'open_source-managed' context in CircleCI is configured with branch-level restrictions, the job will fail on unauthorized branches. Ensure that context permissions in the CircleCI UI are configured to allow access for all branches where this job executes.

- open_source-managed

@gergo-papp gergo-papp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: single-file change to .circleci/config.yml, only the CircleCI context swap to open_source-managed. No other config changes and no leftover references to the old context. LGTM.

@gergo-papp
gergo-papp merged commit 728b67f into main Aug 28, 2026
7 of 10 checks passed
@gergo-papp
gergo-papp deleted the prodsec/fix-security-scans-context branch August 28, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants