🥅 Bound getOps() by the current version in timestamp fetches - #731
Draft
alecgibson wants to merge 1 commit into
Draft
alecgibson wants to merge 1 commit into
alecgibson wants to merge 1 commit into
Conversation
|
coverage: 97.783%. remained the same — pass-current-version-to-get-ops into main |
alecgibson
commented
Sep 30, 2026
At the moment, `_fetchSnapshotByTimestamp()` passes a `null` `to` to
`getOps()` when there's no milestone after the timestamp. An empty
result then looks the same whether the document hasn't changed since
`from` or its ops have been deleted. So a database adapter, or a
wrapper around one, can't flag the missing ops, and we return a blank
or stale snapshot with no error.
We've already fetched the current snapshot by this point, so this
change passes its `v` as `to`. `MemoryDB` is unaffected, since it
already treats a `null` `to` as the end of the op log. For
sharedb-mongo with `getOpsWithoutStrictLinking`, it costs one extra
query on the `{d, v}` index.
Now that `to` is always a number, we also skip `getOps()` when
`from >= to`. `from` can exceed `to`, since milestones are looked up
by `m.mtime`, which a retried submit keeps from its first attempt.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
alecgibson
force-pushed
the
pass-current-version-to-get-ops
branch
from
September 30, 2026 18:41
6060e18 to
587d32f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
_fetchSnapshotByTimestamp()passes anulltotogetOps()when there's no milestone after the timestamp. An empty result then looks the same whether the document hasn't changed sincefromor its ops have been deleted. So a database adapter, or a wrapper around one, can't flag the missing ops, and we return a blank or stale snapshot with no error.We've already fetched the current snapshot by this point, so this change passes its
vasto.MemoryDBis unaffected, since it already treats anulltoas the end of the op log. For sharedb-mongo withgetOpsWithoutStrictLinking, it costs one extra query on the{d, v}index.Now that
tois always a number, we also skipgetOps()whenfrom >= to.fromcan exceedto, since milestones are looked up bym.mtime, which a retried submit keeps from its first attempt.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com