You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
New web/nodejs specific targets may be added, which will warrant deprecation of out-of-box support of wasm32-unknown-unknown target. See: New targets rustwasm/team#38
Following those changes may cause getrandom build breakage for some users, e.g. even if we'll write stdweb = ["wasm-indgen"] in Cargo.toml it may break build for users of older stdweb versions. Thus I believe we should think about how those changes can be handled in future.
I see 3 options:
Publish v0.2 on each deprecation, it's the most conservative option, but will cause a great deal of churn, because we will have to do breaking releases for downstream rand crates.
State that both WASM features are experimental and not covered by backward compatibility promise.
There currently aren't any plans to add more web/nodejs-specific targets AFAIK. There's been ideas of maybe we should in the past, but currently there are now plans to add more.
Ideally this crate would support the wasm32 targets without manually opting in to a feature, but requiring one isn't necessarily the end of the world.
The simplest option would just be to deprecate the stdweb feature at some point, and tell users that they must be using a recent enough version of stdweb and enable the wasm-bindgen feature.
I guess we should avoid releasing version 1.0 before addressing this, but don't see much point worrying about it yet.
As per koute/stdweb#318stdweb is now compatible with wasm-bindgen. Though IIUC it's not build on top of it, so some users use stdweb without wasm-bindgen.
Thus the question is: should we deprecate stdweb feature or leave everything as-is?
I suggest we don't deprecate stdweb unless/until we have a good reason, but am not strongly opinionated on this.
Note regarding possible std integration: I think the most likely option would be not to support either of these within std, and instead use whatever mechanism were available for no_std support to provide the back-end via an external crate. In contrast, the new WASI back-end could probably be integrated (it requires only libc). [Thus it should be irrelevant to this discussion.]
Activity
alexcrichton commentedon Mar 25, 2019
There currently aren't any plans to add more web/nodejs-specific targets AFAIK. There's been ideas of maybe we should in the past, but currently there are now plans to add more.
Ideally this crate would support the wasm32 targets without manually opting in to a feature, but requiring one isn't necessarily the end of the world.
dhardy commentedon Mar 25, 2019
The simplest option would just be to deprecate the
stdwebfeature at some point, and tell users that they must be using a recent enough version ofstdweband enable thewasm-bindgenfeature.I guess we should avoid releasing version 1.0 before addressing this, but don't see much point worrying about it yet.
newpavlov commentedon Apr 9, 2019
As per koute/stdweb#318
stdwebis now compatible withwasm-bindgen. Though IIUC it's not build on top of it, so some users usestdwebwithoutwasm-bindgen.Thus the question is: should we deprecate
stdwebfeature or leave everything as-is?dhardy commentedon Apr 9, 2019
I suggest we don't deprecate
stdwebunless/until we have a good reason, but am not strongly opinionated on this.Note regarding possible
stdintegration: I think the most likely option would be not to support either of these withinstd, and instead use whatever mechanism were available forno_stdsupport to provide the back-end via an external crate. In contrast, the new WASI back-end could probably be integrated (it requires onlylibc). [Thus it should be irrelevant to this discussion.]newpavlov commentedon May 30, 2019
I guess we can close this issue.